Skip to content

[Backport 2.x] Fix deletion permits flow in RemoteFsTimestampAwareTranslog#16336

Merged
dbwiddis merged 1 commit into2.xfrom
backport/backport-16282-to-2.x
Oct 16, 2024
Merged

[Backport 2.x] Fix deletion permits flow in RemoteFsTimestampAwareTranslog#16336
dbwiddis merged 1 commit into2.xfrom
backport/backport-16282-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Oct 15, 2024

Backport 23d1c7a from #16282.

@github-actions
Fix deletion permits flow in RemoteFsTimestampAwareTranslog (#16282)
ce20379 
---------

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
(cherry picked from commit 23d1c7a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 15, 2024

❌ Gradle check result for ce20379: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 15, 2024

❌ Gradle check result for ce20379: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Oct 15, 2024
Open
Open
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 16, 2024

❌ Gradle check result for ce20379: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 16, 2024

✅ Gradle check result for ce20379: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 58.18182% with 23 lines in your changes missing coverage. Please review.

Project coverage is 71.75%. Comparing base (b68fff8) to head (ce20379).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...index/translog/RemoteFsTimestampAwareTranslog.java 44.00% 14 Missing ⚠️
...dex/translog/transfer/TranslogTransferManager.java 79.16% 4 Missing and 1 partial ⚠️
...rg/opensearch/index/translog/RemoteFsTranslog.java 33.33% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16336      +/-   ##
============================================
- Coverage     71.75%   71.75%   -0.01%     
- Complexity    65036    65077      +41     
============================================
  Files          5305     5305              
  Lines        304043   304067      +24     
  Branches      44221    44224       +3     
============================================
+ Hits         218176   218180       +4     
+ Misses        67717    67677      -40     
- Partials      18150    18210      +60

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit df52485 into 2.x Oct 16, 2024
@github-actions github-actions bot deleted the backport/backport-16282-to-2.x branch October 16, 2024 05:01
This was referenced Oct 16, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dbwiddis @sachinpkale