Skip to content

[Backport 2.x] Fix wrong default value when setting index.number_of_routing_shards to null on index creation#16343

Merged
reta merged 2 commits into2.xfrom
backport/backport-16331-to-2.x
Oct 16, 2024
Merged

[Backport 2.x] Fix wrong default value when setting index.number_of_routing_shards to null on index creation#16343
reta merged 2 commits into2.xfrom
backport/backport-16331-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Oct 16, 2024

Backport a853b75 from #16331.

@github-actions
Fix wrong default value when setting index.number_of_routing_shards t…
b5d6e0d 
…o null on index creation (#16331)

* Fix wrong value when setting index.number_of_routing_shards to null on index creation

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Modify change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
(cherry picked from commit a853b75)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 16, 2024

❌ Gradle check result for b5d6e0d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 16, 2024

❌ Gradle check result for b5d6e0d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 16, 2024

❌ Gradle check result for b5d6e0d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Oct 16, 2024
Open
Open
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 16, 2024

❌ Gradle check result for b5d6e0d: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Update 10_basic.yml
671b2dc 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 16, 2024

❕ Gradle check result for 671b2dc: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.82%. Comparing base (b68fff8) to head (671b2dc).
Report is 6 commits behind head on 2.x.

Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16343      +/-   ##
============================================
+ Coverage     71.75%   71.82%   +0.06%     
- Complexity    65036    65061      +25     
============================================
  Files          5305     5305              
  Lines        304043   304032      -11     
  Branches      44221    44216       -5     
============================================
+ Hits         218176   218377     +201     
+ Misses        67717    67480     -237     
- Partials      18150    18175      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 40f3046 into 2.x Oct 16, 2024
@reta reta added the v2.18.0 Issues and PRs related to version 2.18.0 label Oct 16, 2024
@github-actions github-actions bot deleted the backport/backport-16331-to-2.x branch October 16, 2024 13:27
@reta reta mentioned this pull request Oct 16, 2024
Merged
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

v2.18.0 Issues and PRs related to version 2.18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@reta