Skip to content

[Backport 2.x] [Streaming Indexing] Fix intermittent 'The bulk request must be terminated by a newline [\n]' failures#16353

Merged
reta merged 1 commit into2.xfrom
backport/backport-16337-to-2.x
Oct 16, 2024
Merged

[Backport 2.x] [Streaming Indexing] Fix intermittent 'The bulk request must be terminated by a newline [\n]' failures#16353
reta merged 1 commit into2.xfrom
backport/backport-16337-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Oct 16, 2024

Backport ec7b652 from #16337.

@github-actions
[Streaming Indexing] Fix intermittent 'The bulk request must be termi…
aec501b 
…nated by a newline [\n]' failures (#16337)

* [Streaming Indexing] Fix intermittent 'The bulk request must be terminated by a newline [\n]' failures

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Address code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit ec7b652)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@reta reta added v2.18.0 Issues and PRs related to version 2.18.0 bug Something isn't working labels Oct 16, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 16, 2024

❌ Gradle check result for aec501b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 16, 2024

❌ Gradle check result for aec501b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 16, 2024

❕ Gradle check result for aec501b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.81%. Comparing base (40e4a54) to head (aec501b).
Report is 4 commits behind head on 2.x.

Additional details and impacted files 
@@            Coverage Diff            @@
##                2.x   #16353   +/-   ##
=========================================
  Coverage     71.81%   71.81%           
- Complexity    65072    65092   +20     
=========================================
  Files          5305     5304    -1     
  Lines        304056   304051    -5     
  Branches      44219    44219           
=========================================
+ Hits         218356   218369   +13     
+ Misses        67500    67496    -4     
+ Partials      18200    18186   -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 12df195 into 2.x Oct 16, 2024
@github-actions github-actions bot deleted the backport/backport-16337-to-2.x branch October 16, 2024 18:02
This was referenced Oct 16, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

bug Something isn't working v2.18.0 Issues and PRs related to version 2.18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@reta