Skip to content

[Backport 2.x] [Snapshot V2] Do orphan timestamp cleanup before completing the snapshot#16385

Merged
dbwiddis merged 1 commit into
2.xfrom
backport/backport-16365-to-2.x
Oct 19, 2024
Merged

[Backport 2.x] [Snapshot V2] Do orphan timestamp cleanup before completing the snapshot#16385
dbwiddis merged 1 commit into
2.xfrom
backport/backport-16365-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot Bot commented Oct 18, 2024

Backport f1c98a4 from #16365.

@github-actions
Do orphan timestamp cleanup before completing the snapshot (#16365)
68b1f4f 
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
(cherry picked from commit f1c98a4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 18, 2024

❌ Gradle check result for 68b1f4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 18, 2024
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 19, 2024

❌ Gradle check result for 68b1f4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 19, 2024

❌ Gradle check result for 68b1f4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Oct 19, 2024
Open
Open
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 19, 2024

❌ Gradle check result for 68b1f4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 19, 2024

✅ Gradle check result for 68b1f4f: SUCCESS

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.81%. Comparing base (6db8124) to head (68b1f4f).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ava/org/opensearch/snapshots/SnapshotsService.java 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16385      +/-   ##
============================================
- Coverage     71.82%   71.81%   -0.02%     
+ Complexity    65108    65085      -23     
============================================
  Files          5304     5304              
  Lines        304138   304135       -3     
  Branches      44232    44231       -1     
============================================
- Hits         218446   218409      -37     
+ Misses        67535    67477      -58     
- Partials      18157    18249      +92

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 19, 2024
Open
@dbwiddis dbwiddis merged commit 96fdbfd into 2.x Oct 19, 2024
@github-actions github-actions Bot deleted the backport/backport-16365-to-2.x branch October 19, 2024 17:21
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sachinpkale sachinpkale sachinpkale approved these changes

@dbwiddis dbwiddis dbwiddis approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE

@dblock dblock Awaiting requested review from dblock

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sachinpkale @dbwiddis