Skip to content

BugFix - Extract snapshot UUID from pinned entity correctly#16398

Merged
gbbafna merged 1 commit into
opensearch-project:mainfrom
gbbafna:snapUUID_correct
Oct 21, 2024
Merged

BugFix - Extract snapshot UUID from pinned entity correctly#16398
gbbafna merged 1 commit into
opensearch-project:mainfrom
gbbafna:snapUUID_correct

Conversation

@gbbafna
Copy link
Copy Markdown
Contributor

@gbbafna gbbafna commented Oct 21, 2024

Description

Snapshot UUID itself can have __ . While extracting Snapshot UUID from pinned entity, we need to factor it in as well .

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 346fc4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 346fc4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❕ Gradle check result for 346fc4f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.98%. Comparing base (0419e5d) to head (346fc4f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16398      +/-   ##
============================================
- Coverage     72.05%   71.98%   -0.08%     
+ Complexity    64874    64832      -42     
============================================
  Files          5308     5308              
  Lines        302727   302728       +1     
  Branches      43734    43734              
============================================
- Hits         218137   217925     -212     
- Misses        66737    66961     +224     
+ Partials      17853    17842      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit c4a9cc1 into opensearch-project:main Oct 21, 2024
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Oct 21, 2024
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Oct 21, 2024
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
(cherry picked from commit c4a9cc1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Oct 21, 2024
…16401)

(cherry picked from commit c4a9cc1)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants