Fixing inline javadocs usage in PaginationStrategy#16428
Merged
dbwiddis merged 1 commit intoopensearch-project:mainfrom Oct 22, 2024
Merged
Fixing inline javadocs usage in PaginationStrategy#16428dbwiddis merged 1 commit intoopensearch-project:mainfrom
dbwiddis merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Harsh Garg <gkharsh@amazon.com>
gargharsh3134
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16428 +/- ##
============================================
- Coverage 72.05% 72.03% -0.03%
+ Complexity 64874 64776 -98
============================================
Files 5308 5308
Lines 302727 302727
Branches 43734 43734
============================================
- Hits 218137 218076 -61
+ Misses 66737 66711 -26
- Partials 17853 17940 +87 ☔ View full report in Codecov by Sentry. |
dbwiddis
approved these changes
Oct 22, 2024
Member
dbwiddis
left a comment
dbwiddis
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the quick fix!
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
Signed-off-by: Harsh Garg <gkharsh@amazon.com> Co-authored-by: Harsh Garg <gkharsh@amazon.com> (cherry picked from commit 20e233e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Oct 22, 2024
(cherry picked from commit 20e233e) Signed-off-by: Harsh Garg <gkharsh@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Harsh Garg <gkharsh@amazon.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jan 21, 2025
…t#16428) Signed-off-by: Harsh Garg <gkharsh@amazon.com> Co-authored-by: Harsh Garg <gkharsh@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the usage of inline javadocs in paginationStrategy interface causing build failures on older jdk versions.
Related Issues
Resolves #16374
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.