rollover alias supports restored searchable snapshot index

[kkewwei]

Description

Using ISM to rollover alias and restore remote index will use _aliases and _rollover api, we should exclude the searchable snapshot index from checkBlock.

Related Issues

Resolves #16419

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

✅ Gradle check result for c9b2ee0: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.05%. Comparing base (0363aa7) to head (33a32a0).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
...dmin/indices/rollover/TransportRolloverAction.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #16483      +/-   ##
============================================
+ Coverage     72.00%   72.05%   +0.04%     
- Complexity    65038    65053      +15     
============================================
  Files          5313     5313              
  Lines        303454   303469      +15     
  Branches      43910    43910              
============================================
+ Hits         218510   218668     +158     
+ Misses        67040    66896     -144     
- Partials      17904    17905       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

❕ Gradle check result for a577a7c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

❕ Gradle check result for d177114: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[kkewwei]

❕ Gradle check result for d177114: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimarySingleReplica #14310

[kkewwei]

@andrross, please have a look when you are free.

[github-actions]

❕ Gradle check result for 4a7bf3d: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

✅ Gradle check result for 9b08dd3: SUCCESS

[github-actions]

✅ Gradle check result for 33a32a0: SUCCESS

[kkewwei]

@andrross, please have a look when you are free.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16483-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4c35a2b418aa4cf14b8f49d7639d386b96752ae8
# Push it to GitHub
git push --set-upstream origin backport/backport-16483-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16483-to-2.x.

[andrross]

It turns out #5277 (from 2 years ago!) was never backported and that is at least one of the causes of the backport conflict here. I'm going to create a backport for #5277 before retrying the backport here.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16483-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4c35a2b418aa4cf14b8f49d7639d386b96752ae8
# Push it to GitHub
git push --set-upstream origin backport/backport-16483-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16483-to-2.x.