[Backport 2.x] Switch from buildSrc/version.properties to Gradle version catalog (gradle/libs.versions.toml) to enable dependabot to perform automated upgrades on common libs (#16284)#16508
Merged
reta merged 6 commits intoopensearch-project:2.xfrom Oct 28, 2024
Conversation
…`gradle/libs.versions.toml`) to enable dependabot to perform automated upgrades on common libs (opensearch-project#16284) * WIP on lib toml Signed-off-by: Craig Perkins <cwperx@amazon.com> * SpotlessApply Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove unnecessary lines Signed-off-by: Craig Perkins <cwperx@amazon.com> * Specify time when dependabot runs Signed-off-by: Craig Perkins <cwperx@amazon.com> * Refer to version from libs.versions.toml Signed-off-by: Craig Perkins <cwperx@amazon.com> * Use version Signed-off-by: Craig Perkins <cwperx@amazon.com> * Specify version catalog Signed-off-by: Craig Perkins <cwperx@amazon.com> * Call .get() Signed-off-by: Craig Perkins <cwperx@amazon.com> * Define version catalog Signed-off-by: Craig Perkins <cwperx@amazon.com> * Use libraries Signed-off-by: Craig Perkins <cwperx@amazon.com> * Downgrade purposefully Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add mavenCentral Signed-off-by: Craig Perkins <cwperx@amazon.com> * Try w/o libraries section Signed-off-by: Craig Perkins <cwperx@amazon.com> * reinstate Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove version.properties Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update syntax Signed-off-by: Craig Perkins <cwperx@amazon.com> * Change back to weekly Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add grpc Signed-off-by: Craig Perkins <cwperx@amazon.com> * Get relative to project root. Relative path not working on windows bc windows had gradle wrapper path Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add minimal version.properties with only opensearch version to accommodate external references Signed-off-by: Craig Perkins <cwperx@amazon.com> * singularize version.properties Signed-off-by: Craig Perkins <cwperx@amazon.com> * Get rootDir Signed-off-by: Craig Perkins <craig5008@gmail.com> * Fix issue loading snapshot Signed-off-by: Craig Perkins <craig5008@gmail.com> * Limit logic to generating version.properties file within buildSrc Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove unused exports Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add import Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove unused code Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove mavenCentral from publication section Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update reactor-netty version Signed-off-by: Craig Perkins <cwperx@amazon.com> * Only keep versions section in toml Signed-off-by: Craig Perkins <cwperx@amazon.com> * Replaces versions catalog TOML parsing with Gradle's VersionCatalogsExtension Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Update bundled_jdk Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update bytebuddy and mockito Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Craig Perkins <craig5008@gmail.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Co-authored-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> (cherry picked from commit af7a067)
cwperks
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
|
❌ Gradle check result for 5b857c6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Contributor
|
❌ Gradle check result for 6b29bab: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Member
Author
Contributor
|
❌ Gradle check result for adc4728: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Member
Author
|
opened an issue for the failing test: #16513 |
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Contributor
|
❌ Gradle check result for de44ed8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
andrross
approved these changes
Oct 28, 2024
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
force-pushed
the
backport-16284-to-2.x
branch
from
45aced6 to
704ea11
Compare
Contributor
|
❌ Gradle check result for 704ea11: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
force-pushed
the
backport-16284-to-2.x
branch
from
e7d7ba2 to
59f434b
Compare
Contributor
|
@cwperks should be all set now, the 2.x JDK version was not correct (should be 21) |
Member
Author
Contributor
reta
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #16284 to 2.x