Skip to content

Remote store restore optimization #16607

Open
prayascoriolis wants to merge 6 commits intoopensearch-project:mainfrom
prayascoriolis:remote-store-restore-optimization-
Open

Remote store restore optimization #16607
prayascoriolis wants to merge 6 commits intoopensearch-project:mainfrom
prayascoriolis:remote-store-restore-optimization-

Conversation

@prayascoriolis
Copy link
Copy Markdown

@prayascoriolis prayascoriolis commented Nov 11, 2024

Description

Key changes made:

  • Added a check to detect if there is preexisting data in the remote store.
  • Modified the copySegmentFiles call to skip remote upload when data already exists by passing null instead of remoteDirectory.
  • Preserved all other functionality including local file copying and verification.

This solution:

  • Prevents unnecessary uploads when restoring from an interop enabled repository.
  • Maintains data consistency by still performing local copies.
  • Preserves existing recovery state tracking and error handling.
  • Optimizes performance by avoiding redundant network transfers.
  • The change is backward compatible and maintains the existing recovery mechanisms while eliminating the unnecessary upload step when data already exists in the remote store.

Related Issues

Resolves #11044

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working good first issue Good for newcomers Storage:Durability Issues and PRs related to the durability framework Storage:Remote labels Nov 11, 2024
@prayascoriolis prayascoriolis mentioned this pull request Nov 11, 2024
Open
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 11, 2024

✅ Gradle check result for a55ff72: SUCCESS

sachinpkale
sachinpkale reviewed Nov 12, 2024
View reviewed changes
server/src/main/java/org/opensearch/index/shard/IndexShard.java Outdated
Map<String, RemoteSegmentStoreDirectory.UploadedSegmentMetadata> uploadedSegments = sourceRemoteDirectory
.getSegmentsUploadedToRemoteStore();
// Checking for existing remote segments in remote
boolean hasPreexistingRemoteData = remoteDirectory != null && !remoteDirectory.getSegmentsUploadedToRemoteStore().isEmpty();
Copy link
Copy Markdown
Member

@sachinpkale sachinpkale Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check if the uploaded data represents latest state?

Copy link
Copy Markdown
Author

@prayascoriolis prayascoriolis Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check latest state of uploaded data implemented

Copy link
Copy Markdown
Member

@sachinpkale sachinpkale Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it is also possible that the remote directory only has a subset of segments present. Instead of 0 or 1, can we only upload segments that are missing?

@prayascoriolis
Check the latest state of uploaded data & add unit tests. Signed-off-…
0bdc6af 
…by: Prayas Kumar <prayas.kumar@coriolis.co.in>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 14, 2024

❌ Gradle check result for 0bdc6af: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 19, 2024

❌ Gradle check result for 4a10493: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

opensearch-trigger-bot bot commented Jan 3, 2025

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jan 3, 2025
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Apr 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bug Something isn't working good first issue Good for newcomers stalled Issues that have stalled Storage:Durability Issues and PRs related to the durability framework Storage:Remote

Projects

Storage Project Board
Status: 🏗 In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Remote Store] Remove redundant uploads while restoring data from snapshot

2 participants

@prayascoriolis @sachinpkale