Update version check in yaml test file for allowing composite aggregation to run under a parent filter aggregation#16652
Merged
reta merged 1 commit intoopensearch-project:mainfrom Nov 15, 2024
Conversation
…tion to run under a parent filter aggregation Signed-off-by: Gao Binlong <gbinlong@amazon.com>
gaobinlong
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
reta
approved these changes
Nov 15, 2024
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16652 +/- ##
============================================
+ Coverage 71.99% 72.22% +0.22%
- Complexity 65153 65288 +135
============================================
Files 5318 5318
Lines 303903 303903
Branches 43970 43970
============================================
+ Hits 218804 219499 +695
+ Misses 67138 66434 -704
- Partials 17961 17970 +9 ☔ View full report in Codecov by Sentry. |
reta
pushed a commit
that referenced
this pull request
Nov 15, 2024
…tion to run under a parent filter aggregation (#16652) (#16653) (cherry picked from commit efef676) Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jan 21, 2025
…tion to run under a parent filter aggregation (opensearch-project#16652) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the version check from
3.0.0to2.13.0as the change in this PR was released in 2.13.0.Change log is not needed, backport to 2.x is needed.
Related Issues
No issue.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.