Fix the arithmetic long overflow exception with null date values.#16796
Closed
prudhvigodithi wants to merge 1 commit intoopensearch-project:2.xfrom
Closed
Fix the arithmetic long overflow exception with null date values.#16796prudhvigodithi wants to merge 1 commit intoopensearch-project:2.xfrom
prudhvigodithi wants to merge 1 commit intoopensearch-project:2.xfrom
Conversation
Contributor
|
❕ Gradle check result for a28c8cc: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #16796 +/- ##
============================================
+ Coverage 71.74% 71.89% +0.15%
- Complexity 65420 65504 +84
============================================
Files 5314 5314
Lines 305364 305364
Branches 44501 44501
============================================
+ Hits 219077 219549 +472
+ Misses 67952 67501 -451
+ Partials 18335 18314 -21 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Member
Author
|
Closing this based on the comment here #16709 (comment). |
Contributor
|
❌ Gradle check result for 5378859: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PointValues.size()before any date parsing, If there are no points in the segment, we return DISJOINT immediately.Pending to add unit tests.
Related Issues
Related Issue #16709 and coming from #16709 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.