Fix snapshot repository registration failure in mixed OpenSearch version setups

[ashking94]

Description

This PR addresses issue #16830, where snapshot repository registration fails in clusters with mixed OpenSearch versions, specifically when nodes running OS 2.17 are present alongside nodes running earlier 1.x or 2.x versions.

Problem:

• Repository registration fails due to different handling of test paths in OS 2.17 compared to earlier versions.
• This issue occurs during version upgrades, causing snapshot functionality to break.

Solution:

• Implement version-aware logic for handling test paths.
• Ensure backward compatibility with earlier OpenSearch versions.
• Add checks to use the appropriate test path handling method based on the minimum node version in the cluster.

Changes:

1. Modified code to include version checks.
2. Updated test path handling logic to accommodate mixed version scenarios.

Testing:

• Tested repository registration in clusters with:
  • OS 2.15 and OS 2.17 nodes
• Verified successful repository registration in all scenarios.
• Ensured existing functionality remains intact for homogeneous version clusters.

This fix ensures smooth operation of snapshot repositories during cluster upgrades and in environments where different OpenSearch versions coexist.

Related Issues

Resolves #16830

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 2c427aa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[ashking94]

It's difficult to add unit tests as the BlobStoreRepositoryTest.java is actually a single node spin up and testing. There are existing integration tests that invokes this flow. The code is partially tested in the ITs that spins up the remote store nodes.

[github-actions]

❌ Gradle check result for 51a6e67: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[ashking94]

❌ Gradle check result for 51a6e67: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test - #15831

[github-actions]

❌ Gradle check result for 51a6e67: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 51a6e67: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[ashking94]

❌ Gradle check result for 51a6e67: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test - #16015

[github-actions]

✅ Gradle check result for 51a6e67: SUCCESS

[ashking94]

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.15%. Comparing base (5ba909a) to head (51a6e67).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ch/repositories/blobstore/BlobStoreRepository.java 33.33% 0 Missing and 2 partials ⚠️
...nsearch/cluster/service/ClusterApplierService.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

Some of the changes needs mixed version tests for which there is an issue created.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16831-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d37cc9b32600faef17b3c898f8c86b0fd7640d72
# Push it to GitHub
git push --set-upstream origin backport/backport-16831-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16831-to-2.x.

[ashking94]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16831-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d37cc9b32600faef17b3c898f8c86b0fd7640d72
# Push it to GitHub
git push --set-upstream origin backport/backport-16831-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16831-to-2.x.

Manually backporting this PR.

[ashking94]

Created manual backport #16849