Skip to content

[Backport 2.x] Fix multi-value sort for unsigned long#16994

Merged
reta merged 1 commit into2.xfrom
backport/backport-16732-to-2.x
Jan 10, 2025
Merged

[Backport 2.x] Fix multi-value sort for unsigned long#16994
reta merged 1 commit into2.xfrom
backport/backport-16732-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

Backport f6dc4a6 from #16732.

* Fix multi-value sort for unsigned long

Signed-off-by: panguixin <panguixin@bytedance.com>

* Add initial rest-api-spec tests

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* add more rest tests

Signed-off-by: panguixin <panguixin@bytedance.com>

* fix

Signed-off-by: panguixin <panguixin@bytedance.com>

* fix

Signed-off-by: panguixin <panguixin@bytedance.com>

* Extend MultiValueMode with dedicated support of unsigned_long doc values

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Add CHANGELOG.md, minor cleanups

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Correct the license headers

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Correct the @publicapi version

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Replace SingletonSortedNumericUnsignedLongValues with LongToSortedNumericUnsignedLongValues (as per review comments)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit f6dc4a6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for e5c4c1f: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 72.25806% with 43 lines in your changes missing coverage. Please review.

Project coverage is 71.89%. Comparing base (afb2f94) to head (e5c4c1f).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ain/java/org/opensearch/search/MultiValueMode.java 78.16% 15 Missing and 16 partials ⚠️
...elddata/LongToSortedNumericUnsignedLongValues.java 0.00% 9 Missing ⚠️
...comparator/UnsignedLongValuesComparatorSource.java 0.00% 2 Missing ⚠️
...dex/fielddata/SortedNumericUnsignedLongValues.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16994      +/-   ##
============================================
+ Coverage     71.79%   71.89%   +0.10%     
- Complexity    65454    65541      +87     
============================================
  Files          5316     5318       +2     
  Lines        305529   305702     +173     
  Branches      44509    44561      +52     
============================================
+ Hits         219359   219789     +430     
+ Misses        67902    67566     -336     
- Partials      18268    18347      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 2ed6c91 into 2.x Jan 10, 2025
@github-actions github-actions bot deleted the backport/backport-16732-to-2.x branch January 10, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant