[Backport 2.x] Fix multi-value sort for unsigned long#16994
Merged
Conversation
* Fix multi-value sort for unsigned long Signed-off-by: panguixin <panguixin@bytedance.com> * Add initial rest-api-spec tests Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * add more rest tests Signed-off-by: panguixin <panguixin@bytedance.com> * fix Signed-off-by: panguixin <panguixin@bytedance.com> * fix Signed-off-by: panguixin <panguixin@bytedance.com> * Extend MultiValueMode with dedicated support of unsigned_long doc values Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Add CHANGELOG.md, minor cleanups Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Correct the license headers Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Correct the @publicapi version Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Replace SingletonSortedNumericUnsignedLongValues with LongToSortedNumericUnsignedLongValues (as per review comments) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: panguixin <panguixin@bytedance.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit f6dc4a6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
approved these changes
Jan 10, 2025
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #16994 +/- ##
============================================
+ Coverage 71.79% 71.89% +0.10%
- Complexity 65454 65541 +87
============================================
Files 5316 5318 +2
Lines 305529 305702 +173
Branches 44509 44561 +52
============================================
+ Hits 219359 219789 +430
+ Misses 67902 67566 -336
- Partials 18268 18347 +79 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport f6dc4a6 from #16732.