Add support for append only indices#17039
Merged
shwetathareja merged 1 commit intoopensearch-project:mainfrom Jan 28, 2025
Merged
Add support for append only indices#17039shwetathareja merged 1 commit intoopensearch-project:mainfrom
shwetathareja merged 1 commit intoopensearch-project:mainfrom
Conversation
Contributor
|
❌ Gradle check result for 38061f7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
RS146BIJAY
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
dblock,
dbwiddis,
gbbafna,
jainankitk,
jed326,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
RS146BIJAY
changed the title
RS146BIJAY
force-pushed
the
append-only-indices
branch
from
38061f7 to
7af2713
Compare
Contributor
|
❌ Gradle check result for 7af2713: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
mgodwan
reviewed
Jan 21, 2025
Member
mgodwan
left a comment
mgodwan
left a comment
There was a problem hiding this comment.
If indexing into lucene ever causes the version to be greater than 1, should we fail the shard?
libs/common/src/main/java/org/opensearch/common/IndexingRetryException.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/action/bulk/AppendOnlyIndicesIT.java
Outdated
Show resolved
Hide resolved
RS146BIJAY
force-pushed
the
append-only-indices
branch
from
7af2713 to
694c524
Compare
RS146BIJAY
force-pushed
the
append-only-indices
branch
from
8870b45 to
286678a
Compare
RS146BIJAY
added
backport 2.x
RS146BIJAY
force-pushed
the
append-only-indices
branch
from
286678a to
331fc41
Compare
Contributor
server/src/internalClusterTest/java/org/opensearch/action/bulk/AppendOnlyIndicesIT.java
Show resolved
Hide resolved
RS146BIJAY
force-pushed
the
append-only-indices
branch
2 times, most recently
from
e5cef6d to
9051853
Compare
Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
RS146BIJAY
force-pushed
the
append-only-indices
branch
from
9051853 to
1acf39b
Compare
shwetathareja
approved these changes
Jan 28, 2025
Contributor
Contributor
Author
|
Code coverage is taken care by Integ test cases |
Member
|
@RS146BIJAY we will need documentation PR for the new setting |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com> (cherry picked from commit 5e12737) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
Author
Ack. Will raise a separate documentation PR. |
3 tasks
linuxpi
pushed a commit
that referenced
this pull request
Jan 28, 2025
(cherry picked from commit 5e12737) Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Jan 27, 2025
etolbakov
pushed a commit
to etolbakov/OpenSearch
that referenced
this pull request
Jan 29, 2025
Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com> Signed-off-by: Eugene Tolbakov <ev.tolbakov@gmail.com>
2 tasks
This was referenced Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding support for Append only indices where we are disabling any form of updates and deletes on the index. We are also preventing passing a custom doc id for bulk indexing requests. Append only indices will be supported through a configurable setting. If this setting is enabled, all update and delete operations on the index (UPDATE, DELETE, UPSERT, UPDATE BY QUERY, DELETE BY QUERY, etc,) will be blocked.
Related Issues
#12886
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.