[Backport 2.x] Add verbose pipeline parameter to output each processor's execution#17097
Merged
owaiskazi19 merged 3 commits intoJan 23, 2025
Merged
Conversation
…etails (opensearch-project#16843) * Add verbose pipeline parameter to output each processor's execution details Signed-off-by: Junwei Dai <junweid@amazon.com> * add change log Signed-off-by: Junwei Dai <junweid@amazon.com> # Conflicts: # CHANGELOG.md * Refactor ProcessorExecutionDetail to improve field handling Signed-off-by: Junwei Dai <junweid@amazon.com> * Fix ITtest Fail Signed-off-by: Junwei Dai <junweid@amazon.com> * Add more unit test Signed-off-by: Junwei Dai <junweid@amazon.com> * resolve comments Signed-off-by: Junwei Dai <junweid@amazon.com> * 1.add todo to change version.current 2.use exist xcontentUtil to read 3.move processor excution key to ProcessorExecutionDetail Signed-off-by: Junwei Dai <junweid@amazon.com> * refactor code Signed-off-by: Junwei Dai <junweid@amazon.com> * refactor code based on the comment Signed-off-by: Junwei Dai <junweid@amazon.com> * refactor code based on the comment Signed-off-by: Junwei Dai <junweid@amazon.com> * 1.add javadoc 2.refactor error message Signed-off-by: Junwei Dai <junweid@amazon.com> * change error message Signed-off-by: Junwei Dai <junweid@amazon.com> * 1.Added wrappers for tracking execution details of search processors. 2.Removed redundant logic for cleaner and simpler implementation. Signed-off-by: Junwei Dai <junweid@amazon.com> * change version to 3.0.0 Signed-off-by: Junwei Dai <junweid@amazon.com> * fix unit test Signed-off-by: Junwei Dai <junweid@amazon.com> * fix unit test Signed-off-by: Junwei Dai <junweid@amazon.com> * addressed comments 1. removed unnecessary log Signed-off-by: Junwei Dai <junweid@amazon.com> * addressed comments Signed-off-by: Junwei Dai <junweid@amazon.com> * revise comment to opensearch.api Signed-off-by: Junwei Dai <junweid@amazon.com> * removed unused logger and comment Signed-off-by: Junwei Dai <junweid@amazon.com> * removed unnecessary try catch block. add more comment Signed-off-by: Junwei Dai <junweid@amazon.com> * addressed comments Signed-off-by: Junwei Dai <junweid@amazon.com> * remove wrong unit test Signed-off-by: Junwei Dai <junweid@amazon.com> --------- Signed-off-by: Junwei Dai <junweid@amazon.com> Co-authored-by: Junwei Dai <junweid@amazon.com> (cherry picked from commit e15f712) Signed-off-by: Junwei Dai <junweid@amazon.com>
3 tasks
Contributor
Contributor
Author
Contributor
|
@junweid62 -- can you add an override constructor to The "Detect Breaking Changes" action is complaining about the fact that you modified an existing constructor rather than adding an override: You need to add a constructor that has the old signature that delegates to |
added 2 commits
January 23, 2025 10:38
Signed-off-by: Junwei Dai <junweid@amazon.com>
Signed-off-by: Junwei Dai <junweid@amazon.com>
Contributor
owaiskazi19
approved these changes
Jan 23, 2025
Member
|
@msfroh @junweid62 we can add this constructor back on |
Contributor
We don't need to. The 3.0 release is allowed to introduce API changes. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport e15f712 from #16843.
Update version check to onOrAfter(Version.V_2_19_0)
Perform the BWC process:
1. Do this on main with onOrAfter(Version.V_3_0_0)). Get it merged.
2. You'll need a manual backport to 2.x, where you do onOrAfter(Version.V_2_19_0). Don't get it merged right away.
3. Before merging the backport to 2.x, open another PR on main to change it to onOrAfter(Version.V_2_19_0).
4. Merge the backport PR.
5. Merge the main version update PR.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.