Move o.o.action.support.master classes#17104
Merged
andrross merged 1 commit intoopensearch-project:mainfrom Jan 24, 2025
Merged
Move o.o.action.support.master classes#17104andrross merged 1 commit intoopensearch-project:mainfrom
andrross merged 1 commit intoopensearch-project:mainfrom
Conversation
andrross
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
ashking94,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
jed326,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
>breaking
andrross
force-pushed
the
ack-response
branch
from
aa80c2f to
94ad333
Compare
Contributor
|
❌ Gradle check result for 94ad333: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
I could be mistaken, but I think the build failed as a result of #17098 not being merged yet. |
reta
approved these changes
Jan 24, 2025
Move AcknowledgedResponse, AcknowledgedRequest, AcknowledgedRequestBuilder,and ShardsAcknowledgedResponse to "clustermanager" Java package. This is a purely structural move done via the IDE with no logic changes. Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross
force-pushed
the
ack-response
branch
from
94ad333 to
e1abfba
Compare
Contributor
|
❌ Gradle check result for e1abfba: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17104 +/- ##
=========================================
Coverage 72.30% 72.31%
+ Complexity 65482 65425 -57
=========================================
Files 5309 5309
Lines 304324 304324
Branches 44132 44132
=========================================
+ Hits 220056 220058 +2
+ Misses 66259 66204 -55
- Partials 18009 18062 +53 ☔ View full report in Codecov by Sentry. |
msfroh
approved these changes
Jan 24, 2025
This was referenced Jan 21, 2025
expani
pushed a commit
to expani/OpenSearch
that referenced
this pull request
Jan 27, 2025
Move AcknowledgedResponse, AcknowledgedRequest, AcknowledgedRequestBuilder,and ShardsAcknowledgedResponse to "clustermanager" Java package. This is a purely structural move done via the IDE with no logic changes. Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: expani <anijainc@amazon.com>
etolbakov
pushed a commit
to etolbakov/OpenSearch
that referenced
this pull request
Jan 29, 2025
Move AcknowledgedResponse, AcknowledgedRequest, AcknowledgedRequestBuilder,and ShardsAcknowledgedResponse to "clustermanager" Java package. This is a purely structural move done via the IDE with no logic changes. Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Eugene Tolbakov <ev.tolbakov@gmail.com>
8 tasks
This was referenced Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move AcknowledgedResponse, AcknowledgedRequest, AcknowledgedRequestBuilder,and ShardsAcknowledgedResponse to "clustermanager" Java package. This is a purely structural move done via the IDE with no logic changes.
Related Issues
Resolves #4856
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.