Replace usage of transitive shaded dependency#17194
Merged
msfroh merged 1 commit intoopensearch-project:mainfrom Jan 30, 2025
Merged
Replace usage of transitive shaded dependency#17194msfroh merged 1 commit intoopensearch-project:mainfrom
msfroh merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
ashking94,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
|
yes, good catch! |
Contributor
|
curious, how was it detected and does it have some effect? |
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17194 +/- ##
============================================
+ Coverage 72.41% 72.44% +0.03%
- Complexity 65626 65784 +158
============================================
Files 5306 5319 +13
Lines 304927 305717 +790
Branches 44257 44352 +95
============================================
+ Hits 220804 221487 +683
- Misses 66007 66092 +85
- Partials 18116 18138 +22 ☔ View full report in Codecov by Sentry. |
reta
approved these changes
Jan 29, 2025
Member
Author
@yupeng9 It was not causing any problem. I just happened to notice it after I merged the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yupeng9 Looks like we missed one usage of shaded immutable map.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.