Fix flaky test RemoteIndexRecoveryIT.testRerouteRecovery#17228
Merged
sachinpkale merged 1 commit intoMar 4, 2025
Conversation
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Contributor
|
❌ Gradle check result for 3a2e2f3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
sachinpkale
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
|
❌ Gradle check result for 3a2e2f3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17228 +/- ##
============================================
+ Coverage 72.24% 72.29% +0.05%
+ Complexity 65704 65660 -44
============================================
Files 5318 5318
Lines 305674 305674
Branches 44349 44349
============================================
+ Hits 220834 220991 +157
+ Misses 66769 66521 -248
- Partials 18071 18162 +91 ☔ View full report in Codecov by Sentry. |
gbbafna
approved these changes
Mar 3, 2025
mayanksharma27
pushed a commit
to mayanksharma27/OpenSearch
that referenced
this pull request
Mar 5, 2025
…project#17228) Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Mar 18, 2025
…project#17228) Signed-off-by: Sachin Kale <sachinpkale@gmail.com> Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IndexRecoveryIT.testRerouteRecoverytriggers shard movement and verifies few details while recovery is in progress. It also slows down recovery to make sure that shard is not moved before we assert.RemoteIndexRecoveryIT extendsIndexRecoveryIT`, we reduced number of docs to be ingested by 5x (this is to decrease test run time as latency of ingestion is higher with remote store enabled).OpenSearch/server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteIndexRecoveryIT.java
Lines 67 to 70 in c06f53e
Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.