fix explain action on query rewrite#17277
Closed
fen-qin wants to merge 2 commits intoopensearch-project:mainfrom
Closed
fix explain action on query rewrite#17277fen-qin wants to merge 2 commits intoopensearch-project:mainfrom
fen-qin wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Fen Qin <“mfenqin@amazon.com”>
bzhangam
reviewed
Feb 6, 2025
server/src/main/java/org/opensearch/action/explain/TransportExplainAction.java
Show resolved
Hide resolved
bzhangam
reviewed
Feb 6, 2025
server/src/main/java/org/opensearch/action/explain/TransportExplainAction.java
Show resolved
Hide resolved
Contributor
|
❌ Gradle check result for b1f53c0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for 11ebc0d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is an exception when call explain in "by_doc_id" mode. Response looks like this:
The error were caught from
TransportExplainAction -> Rewriteable.javabecause there still be asyncActions left when the flagassertNoAsyncTasksreturned as true.The conflict is down to:
The NeuralQueryBuilder
doRewritemethod introduces asynchronous actions viaqueryRewriteContext.registerAsyncAction. So it then returns a context with potentially unresolved async tasks.Rewritable.rewritethen checksassertNoAsyncTasksflag, throws the exception if there exists any async tasks left.Fix in this PR is resolve this conflict:
TransportExplainAction.Related Issues
Resolves - opensearch-project/neural-search#1126
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.