Fix ignore_malformed index-level override#17319
Closed
afshirazi wants to merge 3 commits into
Closed
Conversation
Signed-off-by: Ali Shirazi <ali.shirazi@array.world>
Signed-off-by: Ali Shirazi <ali.shirazi@array.world>
afshirazi
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
Bot
added
bug
Signed-off-by: Ali Shirazi <ali.shirazi@array.world>
Contributor
|
❌ Gradle check result for d098247: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Author
|
Sorry for the late update. This PR is proving to be more work than I anticipated, and I don't foresee myself having the time to fix it soon. I'll pull out of this one unfortunately. @andrross I put my findings in the issue, in case someone else wants to take the same approach. Apologies again :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request reverts code from #4494, which caused index-level
ignore_malformedsettings to override field-level ones, and implements an alternative in DocumentParserRelated Issues
Resolves #16599
Related to #4002
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.