[Clone] [Security Manager Replacement] Native Java Agent by kumargu · Pull Request #17517 · opensearch-project/OpenSearch

kumargu · 2025-03-05T07:11:20Z

Clone of original implementation of Java agent

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2025-03-05T07:35:44Z

❌ Gradle check result for 1b6692e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-05T08:18:00Z

❌ Gradle check result for 2fcdd44: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-05T09:38:16Z

❌ Gradle check result for 21e708c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-05T15:34:35Z

❌ Gradle check result for e8aab30: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-05T16:15:31Z

❌ Gradle check result for dbbef0e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-05T18:37:03Z

❌ Gradle check result for 1923e2d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-05T19:03:31Z

❌ Gradle check result for 5cb1c07: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-05T19:31:52Z

❌ Gradle check result for 51328a0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-06T08:57:44Z

❌ Gradle check result for 447c4a8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-06T09:30:12Z

❌ Gradle check result for 88f3d6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-06T11:06:57Z

❌ Gradle check result for ae3e3c2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-06T11:58:04Z

❌ Gradle check result for a5c15b4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-06T14:09:31Z

❌ Gradle check result for 5a51029: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-06T14:40:06Z

❌ Gradle check result for bfe165f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

kumargu · 2025-03-06T16:26:51Z

❌ Gradle check result for bfe165f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peterzhuamazon would you know if I can run this check locally and fix it faster? thanks!

github-actions · 2025-03-13T10:40:57Z

❕ Gradle check result for 1483b8b: UNSTABLE

TEST FAILURES:

      4 org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.classMethod
      2 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode
      1 org.opensearch.action.admin.indices.create.CreateIndexIT.testCreateAndDeleteIndexConcurrently
      1 org.opensearch.action.admin.indices.create.CreateIndexIT.classMethod

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Gulshan Kumar <kumargu@amazon.com>

peterzhuamazon · 2025-03-13T11:43:39Z

Commit sha: e36c1e5, Author: Gulshan, Committer: Gulshan; Expected "Gulshan kumargu@amazon.com", but got "Gulshan Kumar kumargu@amazon.com".

github-actions · 2025-03-13T12:06:48Z

❌ Gradle check result for e36c1e5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

peterzhuamazon · 2025-03-13T12:24:09Z

CHANGELOG-3.0.md

 - [Star Tree] [Search] Resolving keyword & numeric bucket aggregation with metric aggregation using star-tree ([#17165](https://github.com/opensearch-project/OpenSearch/pull/17165))
 - Added error handling support for the pull-based ingestion ([#17427](https://github.com/opensearch-project/OpenSearch/pull/17427))
-
+- A Java Agent for intercepting socket operation and enforcing a security policy to it.


Suggested change

- A Java Agent for intercepting socket operation and enforcing a security policy to it.

- A Java Agent for intercepting socket operation and enforcing a security policy to it ([#17517](https://github.com/opensearch-project/OpenSearch/pull/17517))

reta · 2025-03-13T14:17:01Z

libs/agent-sm/agent/src/main/java/org/opensearch/javaagent/SocketChannelInterceptor.java

-
-                final SocketPermission permission = new SocketPermission(host, "connect,resolve");
+                final SocketPermission connectResolve = new SocketPermission(host, "connect,resolve");
+                final SocketPermission listenResolve = new SocketPermission(host, "listen,resolve");


@kumargu I am not sure what exactly you are trying to fix here: we are intercepting SocketChannel:connect only which connects to remote address. The listen is not applicable here, we are not be listening on a socket (this is ServerSocketChannel responsibility). Could you please clarify this change?

I was trying to fix this test failure. Looking at the trace, I think it fails with while attempting "listen & resolve" from localhost:0

I had a similar assumption that we are only dealing with SocketChannel:connect but all my efforts to just play around with the policy file didn't work-out and this particular does seem to work.

Thanks @kumargu , I will take a look shortly

kumargu · 2025-03-17T17:43:39Z

{"run-benchmark-test": "id_3"}

Signed-off-by: Gulshan <71965388+kumargu@users.noreply.github.com>

github-actions · 2025-03-17T18:26:24Z

❌ Gradle check result for 96daf8f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-17T19:00:23Z

The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2615/ . Final results will be published once the job is completed.

opensearch-ci-bot · 2025-03-17T19:11:46Z

The benchmark job https://build.ci.opensearch.org/job/benchmark-pull-request/2615/ failed.
Please see logs to debug.

kumargu force-pushed the kumargu_java_agent_v1 branch from 2fcdd44 to 21e708c Compare March 5, 2025 09:09

kumargu force-pushed the kumargu_java_agent_v1 branch from 21e708c to e8aab30 Compare March 5, 2025 15:00

kumargu force-pushed the kumargu_java_agent_v1 branch from e8aab30 to dbbef0e Compare March 5, 2025 15:50

kumargu force-pushed the kumargu_java_agent_v1 branch from dbbef0e to 1923e2d Compare March 5, 2025 18:13

kumargu force-pushed the kumargu_java_agent_v1 branch from 1923e2d to 5cb1c07 Compare March 5, 2025 18:42

kumargu force-pushed the kumargu_java_agent_v1 branch from 5cb1c07 to 51328a0 Compare March 5, 2025 19:08

kumargu force-pushed the kumargu_java_agent_v1 branch from 51328a0 to 447c4a8 Compare March 6, 2025 08:23

kumargu force-pushed the kumargu_java_agent_v1 branch from 447c4a8 to 88f3d6f Compare March 6, 2025 09:01

kumargu force-pushed the kumargu_java_agent_v1 branch 3 times, most recently from 12d3cc3 to ae3e3c2 Compare March 6, 2025 10:36

kumargu force-pushed the kumargu_java_agent_v1 branch from ae3e3c2 to a5c15b4 Compare March 6, 2025 11:35

kumargu force-pushed the kumargu_java_agent_v1 branch from a5c15b4 to 5a51029 Compare March 6, 2025 13:44

kumargu force-pushed the kumargu_java_agent_v1 branch from 5a51029 to bfe165f Compare March 6, 2025 14:16

kumargu force-pushed the kumargu_java_agent_v1 branch from bfe165f to 1bc341c Compare March 6, 2025 17:56

kumargu force-pushed the kumargu_java_agent_v1 branch 3 times, most recently from d5e1c00 to 1483b8b Compare March 13, 2025 09:49

Fix tests

e36c1e5

Signed-off-by: Gulshan Kumar <kumargu@amazon.com>

kumargu force-pushed the kumargu_java_agent_v1 branch from 1483b8b to e36c1e5 Compare March 13, 2025 11:17

peterzhuamazon reviewed Mar 13, 2025

View reviewed changes

This was referenced Mar 13, 2025

[AUTOCUT] Gradle Check Flaky Test Report for S3BlobStoreRepositoryTests #14299

Open

[AUTOCUT] Gradle Check Flaky Test Report for IndicesRequestCacheCleanupIT #15822

Open

[AUTOCUT] Gradle Check Flaky Test Report for ResourceAwareTasksTests #14293

Closed

reta reviewed Mar 13, 2025

View reviewed changes

opensearch-ci-bot mentioned this pull request Mar 14, 2025

[AUTOCUT] Gradle Check Flaky Test Report for MultiOrdinalsTests #17588

Open

github-actions bot mentioned this pull request Mar 17, 2025

Manual approval required for workflow run 13906250128: Request to approve/deny benchmark run for PR #17517 #17610

Closed

Merge branch 'main' into kumargu_java_agent_v1

96daf8f

Signed-off-by: Gulshan <71965388+kumargu@users.noreply.github.com>

This was referenced Mar 17, 2025

[AUTOCUT] Gradle Check Flaky Test Report for QueueResizableOpenSearchThreadPoolExecutorTests #14297

Open

[AUTOCUT] Gradle Check Flaky Test Report for ReactorNetty4StreamingStressIT #15840

Closed

kumargu closed this Mar 19, 2025

opensearch-ci-bot mentioned this pull request Mar 21, 2025

[AUTOCUT] Gradle Check Flaky Test Report for SearchRestCancellationIT #14311

Open

kumargu mentioned this pull request Mar 25, 2025

[Feature Request] OSB based Performance benchmark with Java Agent #17665

Closed

opensearch-ci-bot mentioned this pull request Mar 26, 2025

[AUTOCUT] Gradle Check Flaky Test Report for HaHdfsFailoverTestSuiteIT #17692

Open

opensearch-ci-bot mentioned this pull request Apr 14, 2025

[AUTOCUT] Gradle Check Flaky Test Report for CreateIndexIT #14312

Open

This was referenced Apr 24, 2025

[AUTOCUT] Gradle Check Flaky Test Report for SimpleSecureNetty4TransportTests #18071

Open

[AUTOCUT] Gradle Check Flaky Test Report for TieredSpilloverCacheStatsIT #14300

Closed

opensearch-ci-bot mentioned this pull request Jun 18, 2025

[AUTOCUT] Gradle Check Flaky Test Report for SearchWeightedRoutingIT #15843

Open

	- A Java Agent for intercepting socket operation and enforcing a security policy to it.
	- A Java Agent for intercepting socket operation and enforcing a security policy to it ([#17517](https://github.com/opensearch-project/OpenSearch/pull/17517))

Conversation

kumargu commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

kumargu commented Mar 6, 2025

Uh oh!

github-actions bot commented Mar 13, 2025

Uh oh!

peterzhuamazon commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 13, 2025

Uh oh!

peterzhuamazon Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

kumargu Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

reta Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

kumargu Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

kumargu Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

reta Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

kumargu Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

kumargu commented Mar 17, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

opensearch-ci-bot commented Mar 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

peterzhuamazon commented Mar 13, 2025 •

edited

Loading