Pagination for wlm/stats api#17638
Conversation
Lindsay-00
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
|
❌ Gradle check result for ad612da: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for baa30b0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/action/pagination/WlmPaginationStrategy.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/pagination/WlmPaginationStrategy.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/pagination/WlmPaginationStrategy.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/pagination/WlmPaginationStrategy.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/rest/action/admin/cluster/RestWlmStatsAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/rest/action/admin/cluster/RestWlmStatsAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/rest/action/admin/cluster/RestWlmStatsAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/rest/action/admin/cluster/RestWlmStatsAction.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/action/pagination/DiscoveryNodeMock.java
Show resolved
Hide resolved
|
❌ Gradle check result for 0dd053d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/action/pagination/WlmPaginationStrategy.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/pagination/WlmPaginationStrategy.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/pagination/WlmPaginationStrategy.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/rest/action/admin/cluster/RestWlmStatsAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/rest/action/admin/cluster/RestWlmStatsAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/rest/action/admin/cluster/RestWlmStatsAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/pagination/SortBy.java
Outdated
Show resolved
Hide resolved
|
Can we provide a better name for this PR and add some description? A single word title is not descriptive |
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
|
@Lindsay-00 - The code coverage for this change is bit low - https://app.codecov.io/gh/opensearch-project/OpenSearch/pull/17638?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=opensearch-project. I am wondering if there is opportunity to improve that by adding few more tests? |
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
|
❌ Gradle check result for e48e03a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
|
❌ Gradle check result for bbad32e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
|
❌ Gradle check result for c808b69: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
|
❕ Gradle check result for 4dbd9e4: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
--------- Signed-off-by: Lingxi Chen <lingxich@amazon.com>
--------- Signed-off-by: Lingxi Chen <lingxich@amazon.com>
--------- Signed-off-by: Lingxi Chen <lingxich@amazon.com>
--------- Signed-off-by: Lingxi Chen <lingxich@amazon.com>
--------- Signed-off-by: Lingxi Chen <lingxich@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
--------- Signed-off-by: Lingxi Chen <lingxich@amazon.com>
--------- Signed-off-by: Lingxi Chen <lingxich@amazon.com>
5 participants
Description
This change addresses a scalability issue in the existing /_wlm/stats API by introducing a new paginated endpoint: /_list/wlm_stats. The original API returns statistics for all nodes and query groups in a single response, which becomes inefficient and resource-intensive as cluster size grows.
This enhancement is part of the ongoing effort to improve observability and scalability in OpenSearch Workload Management, as described in GitHub Issue #17592.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.