Delegate TransportUpdateAction to TransportBulkAction by msfroh · Pull Request #17679 · opensearch-project/OpenSearch

msfroh · 2025-03-25T00:43:03Z

Description

This is consistent with TransportIndexAction and TransportDeleteAction, and ensures that updates behave consistently, whether sent via the _update API or via the _bulk API.

Related Issues

Resolves #16980

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2025-03-25T01:17:49Z

❌ Gradle check result for a432e47: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-25T01:50:05Z

❌ Gradle check result for a432e47: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

andrross · 2025-03-25T22:30:58Z

server/src/main/java/org/opensearch/action/update/TransportUpdateAction.java

-    private final NodeClient client;
-    private final ClusterService clusterService;
+@Deprecated
+public class TransportUpdateAction extends HandledTransportAction<UpdateRequest, UpdateResponse> {


Could we remove this class all together? Seems to not be widely used: https://github.com/search?q=org%3Aopensearch-project%20TransportUpdateAction%20NOT%20is%3Aarchived&type=code

So, the @Deprecated annotation was copied from TransportIndexAction and TransportDeleteAction.

In practice, I don't think I actually want to remove it. I should probably remove the annotation. (We should probably remove the annotations from TransportIndexAction and TransportDeleteAction since I don't think they're ever going to be removed either.)

There -- I removed this annotation and the ones on TransportIndexAction, TransportDeleteAction, and TransportSingleItemBulkAction.

github-actions · 2025-03-25T23:28:24Z

❌ Gradle check result for 22a2df3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-26T22:37:23Z

❌ Gradle check result for c943a65:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-27T00:58:55Z

❌ Gradle check result for c943a65:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-27T23:29:30Z

❌ Gradle check result for c943a65: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-28T18:58:41Z

❌ Gradle check result for ffda134: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-03-31T19:45:19Z

❌ Gradle check result for b179c0f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

server/src/main/java/org/opensearch/action/update/TransportUpdateAction.java

github-actions · 2025-04-04T01:03:30Z

❌ Gradle check result for 07f54e6:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

msfroh · 2025-04-04T20:20:28Z

There are 26 BWC and IT test failures logged in https://build.ci.opensearch.org/job/gradle-check/55554/#showFailuresLink.

Requests originating from 2.x clusters expect to find a shard-level update action.

I'll see if I can bring back the shard-level action for BWC, but mark it as deprecated to be removed in 4.0.

github-actions · 2025-04-04T20:59:32Z

❌ Gradle check result for 1d19b4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This is consistent with TransportIndexAction and TransportDeleteAction, and ensures that updates behave consistently, whether sent via the `_update` API or via the `_bulk` API. Signed-off-by: Michael Froh <froh@amazon.com>

Signed-off-by: Michael Froh <froh@amazon.com>

Since this change modifies how updates behave with ingest pipelines, the tests need to be updated to reflect the new behavior (where single item updates behave the same as bulk updates). Signed-off-by: Michael Froh <froh@amazon.com>

… and children In practice, these adapter classes are unlikely to be removed, unless we drop support (at the API level) for the single-item operations. Since the single item operations are likely to stick around, we have no plan to remove these adapter classes. Signed-off-by: Michael Froh <froh@amazon.com>

Signed-off-by: Michael Froh <froh@amazon.com>

Now that it's not the parent of TransportUpdateAction, it's unused. Signed-off-by: Michael Froh <froh@amazon.com>

In a mixed-cluster environment, nodes running on 2.x will still try to dispatch the node-level update action to 3.x shards. We can't remove the node-level action (in favor of TransportShardBulkAction) until 4.0. Signed-off-by: Michael Froh <froh@amazon.com>

github-actions · 2025-04-04T23:43:10Z

❌ Gradle check result for bc9e705: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

opensearch-trigger-bot · 2025-05-05T15:22:40Z

This PR is stalled because it has been open for 30 days with no activity.

github-actions bot added >breaking Identifies a breaking change. enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing v3.0.0 Issues and PRs related to version 3.0.0 labels Mar 25, 2025

heemin32 approved these changes Mar 25, 2025

View reviewed changes

This was referenced Mar 25, 2025

[AUTOCUT] Gradle Check Flaky Test Report for IngestFromKinesisIT #17678

Open

[AUTOCUT] Gradle Check Flaky Test Report for SecureReactorNetty4HttpServerTransportTests #17486

Closed

andrross reviewed Mar 25, 2025

View reviewed changes

msfroh marked this pull request as ready for review March 25, 2025 23:22

msfroh requested review from Bukhtawar, CEHENKLE, Rishikesh1159, anasalkouz, ashking94, bugmakerrrrrr, cwperks, dblock, dbwiddis, gbbafna, jainankitk, kotwanikunal, linuxpi, mch2, nknize, owaiskazi19, reta, sachinpkale and saratvemulapalli as code owners March 25, 2025 23:22

msfroh requested review from VachaShah, shwetathareja and sohami as code owners March 25, 2025 23:22

msfroh force-pushed the update_as_bulk branch from c943a65 to ffda134 Compare March 28, 2025 18:21

opensearch-ci-bot mentioned this pull request Mar 28, 2025

[AUTOCUT] Gradle Check Flaky Test Report for DeleteByQueryBasicTests #15820

Open

msfroh force-pushed the update_as_bulk branch from ffda134 to b179c0f Compare March 31, 2025 19:06

q-andy mentioned this pull request Mar 31, 2025

[Feature Request] Add configurability to run ingest pipelines during document update operations #17742

Open

opensearch-ci-bot mentioned this pull request Apr 1, 2025

[AUTOCUT] Gradle Check Flaky Test Report for RemoteStoreKafkaIT #17693

Open

q-andy reviewed Apr 1, 2025

View reviewed changes

server/src/main/java/org/opensearch/action/update/TransportUpdateAction.java Show resolved Hide resolved

msfroh added 7 commits April 4, 2025 15:45

Delegate TransportUpdateAction to TransportBulkAction

0a40646

This is consistent with TransportIndexAction and TransportDeleteAction, and ensures that updates behave consistently, whether sent via the `_update` API or via the `_bulk` API. Signed-off-by: Michael Froh <froh@amazon.com>

Add changelog entry

af0c69a

Signed-off-by: Michael Froh <froh@amazon.com>

Update ingest-common REST tests

bcfdf79

Since this change modifies how updates behave with ingest pipelines, the tests need to be updated to reflect the new behavior (where single item updates behave the same as bulk updates). Signed-off-by: Michael Froh <froh@amazon.com>

Fix Javadoc syntax error

0537989

Signed-off-by: Michael Froh <froh@amazon.com>

Remove TransportInstanceSingleOperationAction

ed5f732

Now that it's not the parent of TransportUpdateAction, it's unused. Signed-off-by: Michael Froh <froh@amazon.com>

msfroh force-pushed the update_as_bulk branch from 1d19b4f to bc9e705 Compare April 4, 2025 22:45

opensearch-ci-bot mentioned this pull request Apr 14, 2025

[AUTOCUT] Gradle Check Flaky Test Report for DedicatedClusterSnapshotRestoreIT #15806

Open

opensearch-trigger-bot bot added the stalled Issues that have stalled label May 5, 2025

Conversation

msfroh commented Mar 25, 2025

Description

Related Issues

Check List

Uh oh!

github-actions bot commented Mar 25, 2025

Uh oh!

github-actions bot commented Mar 25, 2025

Uh oh!

andrross Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

msfroh Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

msfroh Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 25, 2025

Uh oh!

github-actions bot commented Mar 26, 2025

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

github-actions bot commented Mar 28, 2025

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

msfroh commented Apr 4, 2025

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

opensearch-trigger-bot bot commented May 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants