Remove NO_MORE_DOCS assertion as Lucene 10 APIs changed

[expani]

Description

We found one failing test here with this draft PR from @msfroh to check which code paths don't honor SortedSetDocValues API constraints.

This fixes the tests affected by assertions on NO_MORE_DOCS in AbstractStringFieldDataTestCase after all ords are iterated over. It was removed in Lucene 10 following deprecation using NO_MORE_ORDS

[github-actions]

❌ Gradle check result for 4d6126e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 7d02b34: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 77a3dbf: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.47%. Comparing base (edd854a) to head (bc66a60).
Report is 17 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #17721      +/-   ##
============================================
- Coverage     72.55%   72.47%   -0.08%     
+ Complexity    65966    65901      -65     
============================================
  Files          5326     5326              
  Lines        305548   305548              
  Branches      44322    44322              
============================================
- Hits         221684   221460     -224     
- Misses        65759    65927     +168     
- Partials      18105    18161      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[msfroh]

Can we replace these with assertions on values.docValueCount()?

[github-actions]

❕ Gradle check result for bc66a60: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[expani]

Thanks for reviewing @msfroh
Added the assertion on docValueCount

[expani]

Closed in favor of #17649