Skip to content

Adding support for derive source feature and implementing it for various type of field mappers#17759

Merged
shwetathareja merged 13 commits intoopensearch-project:mainfrom
tanik98:tanik-derived-source-feature
May 8, 2025
Merged

Adding support for derive source feature and implementing it for various type of field mappers#17759
shwetathareja merged 13 commits intoopensearch-project:mainfrom
tanik98:tanik-derived-source-feature

Conversation

@tanik98
Copy link
Copy Markdown
Contributor

@tanik98 tanik98 commented Apr 2, 2025 •
edited
Loading

Description

  • Adding interface for support of building source using stored/docvalues in FieldMapper
  • Implemented these methods for these fields:
    • Date(millis and nanos)
    • Number(Integer/Long/Unsigned Long/Bytes/Short/Half Float)
    • Scaled Float
    • Boolean
    • Ip
    • Constant Keyword
    • Geo Point
    • Keyword
    • Text
    • Wildcard
  • Tested these changes by integrating the flow with search path and covered tests for both docValues and stored fields.
  • Integration with mapper and search path will be covered in separate PR.

This PR replaces #17383, it was closed due to modification to a branch and is not restorable.

Related Issues

Resolves #17073

Part of feature #9568

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue has been created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@tanik98
Adding support for derive source feature and implementing it for some…
639b436 
… of the field types

Signed-off-by: Tanik Pansuriya <panbhai@amazon.com>
@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Indexing:Performance labels Apr 2, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2025

❌ Gradle check result for 639b436: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@tanik98 tanik98 mentioned this pull request Apr 2, 2025
Closed
3 tasks
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request May 2, 2025
Open
@tanik98
Copy link
Copy Markdown
Contributor Author

tanik98 commented May 6, 2025

@bugmakerrrrrr did you happen to look at the latest revision?

bugmakerrrrrr
bugmakerrrrrr reviewed May 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@bugmakerrrrrr bugmakerrrrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any more questions other than the comments

@tanik98
Handling date_nanos field type and addressing the comments
a28c1ba 
Signed-off-by: Tanik Pansuriya <panbhai@amazon.com>
@tanik98 tanik98 requested a review from bugmakerrrrrr May 6, 2025 20:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 6, 2025

❌ Gradle check result for a28c1ba: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@tanik98
Merge branch 'main' into tanik-derived-source-feature
0e81c7a 
Signed-off-by: tanik98 <72665765+tanik98@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 7, 2025

❌ Gradle check result for 1e9d9a2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@tanik98 tanik98 force-pushed the tanik-derived-source-feature branch from 1e9d9a2 to 897a596 Compare May 7, 2025 09:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 7, 2025

❌ Gradle check result for 897a596: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced May 7, 2025
Closed
Open
Open
Closed
@tanik98
Removing nextOrd() call and directly traversing over valid range for …
51909c7 
…SortedSetDocValues

Signed-off-by: Tanik Pansuriya <panbhai@amazon.com>
@tanik98 tanik98 force-pushed the tanik-derived-source-feature branch from 897a596 to 51909c7 Compare May 7, 2025 16:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 7, 2025

✅ Gradle check result for 51909c7: SUCCESS

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request May 8, 2025
Closed
@shwetathareja shwetathareja merged commit 99642ff into opensearch-project:main May 8, 2025
29 of 30 checks passed
This was referenced May 15, 2025
Open
Open
@BrewTestBot BrewTestBot mentioned this pull request Jun 24, 2025
Merged
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
@tanik98
Adding support for derive source feature and implementing it for vari…
dde4cc8 
…ous type of field mappers (opensearch-project#17759)

* Adding support for derive source feature and implementing it for some of the field types

Signed-off-by: Tanik Pansuriya <panbhai@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jul 3, 2025
Open
@tanik98 tanik98 mentioned this pull request Jul 14, 2025
Merged
3 tasks
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Aug 17, 2025
Open
This was referenced Jan 10, 2026
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwetathareja shwetathareja shwetathareja approved these changes

@mgodwan mgodwan mgodwan approved these changes

@bugmakerrrrrr bugmakerrrrrr bugmakerrrrrr approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

@jainankitk jainankitk Awaiting requested review from jainankitk

@linuxpi linuxpi Awaiting requested review from linuxpi

Assignees

No one assigned

Labels

enhancement Enhancement or improvement to existing feature or request Indexing:Performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Derived Source] Add support for deriving source field in FieldMapper

4 participants

@tanik98 @mgodwan @bugmakerrrrrr @shwetathareja