Approximate match all query with a sort#17772
Approximate match all query with a sort#17772peterzhuamazon merged 9 commits intoopensearch-project:mainfrom
Conversation
|
{"run-benchmark-test": "id_4"} |
|
❌ Gradle check result for f3fc28b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2755/ . Final results will be published once the job is completed. |
f3fc28b to
12d02fb
Compare
|
❌ Gradle check result for c677dc7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
|
❌ Gradle check result for 05168da: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17772 +/- ##
============================================
+ Coverage 72.43% 72.54% +0.11%
- Complexity 66866 66958 +92
============================================
Files 5463 5466 +3
Lines 309485 309581 +96
Branches 45014 45042 +28
============================================
+ Hits 224165 224583 +418
+ Misses 67029 66628 -401
- Partials 18291 18370 +79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Michael Froh <froh@amazon.com>
|
❕ Gradle check result for 9f337cc: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
5938bc8
into
opensearch-project:main
* Adding approximate match all query Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Minor refactor Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix doc field sorting Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix more tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix more tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix backward tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> --------- Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: Michael Froh <froh@amazon.com> Co-authored-by: Michael Froh <froh@amazon.com> Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
* Adding approximate match all query Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Minor refactor Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix doc field sorting Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix more tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix more tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix backward tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> --------- Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: Michael Froh <froh@amazon.com> Co-authored-by: Michael Froh <froh@amazon.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
* Adding approximate match all query Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Minor refactor Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix doc field sorting Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix more tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix more tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix backward tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> --------- Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: Michael Froh <froh@amazon.com> Co-authored-by: Michael Froh <froh@amazon.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Description
Similar to #13788, introducing an
ApproximateMatchAllQuery, that essentially adds a bounded range to the top level query. This should in turn delegate to theApproximatePointRangeQueryand short circuit after collecting 10,000 docs. Thanks to @msfroh, this is identical to #16321.This PR needs to merged after #17769
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.