Skip to content

Approximate match all query with a sort#17772

Merged
peterzhuamazon merged 9 commits intoopensearch-project:mainfrom
harshavamsi:approximate_match_all
Apr 11, 2025
Merged

Approximate match all query with a sort#17772
peterzhuamazon merged 9 commits intoopensearch-project:mainfrom
harshavamsi:approximate_match_all

Conversation

@harshavamsi
Copy link
Copy Markdown
Contributor

@harshavamsi harshavamsi commented Apr 3, 2025

Description

Similar to #13788, introducing an ApproximateMatchAllQuery, that essentially adds a bounded range to the top level query. This should in turn delegate to the ApproximatePointRangeQuery and short circuit after collecting 10,000 docs. Thanks to @msfroh, this is identical to #16321.

This PR needs to merged after #17769

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@harshavamsi
Copy link
Copy Markdown
Contributor Author

{"run-benchmark-test": "id_4"}

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2025

❌ Gradle check result for f3fc28b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2025

The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2755/ . Final results will be published once the job is completed.

@harshavamsi harshavamsi force-pushed the approximate_match_all branch from f3fc28b to 12d02fb Compare April 3, 2025 04:32
@github-project-automation github-project-automation bot moved this from In Progress to Done in Performance Roadmap Apr 11, 2025
@harshavamsi harshavamsi reopened this Apr 11, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Performance Roadmap Apr 11, 2025
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for c677dc7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 05168da: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 93877ef: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 10 lines in your changes missing coverage. Please review.

Project coverage is 72.54%. Comparing base (07cb4c9) to head (9f337cc).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...h/search/approximate/ApproximateMatchAllQuery.java 70.58% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17772      +/-   ##
============================================
+ Coverage     72.43%   72.54%   +0.11%     
- Complexity    66866    66958      +92     
============================================
  Files          5463     5466       +3     
  Lines        309485   309581      +96     
  Branches      45014    45042      +28     
============================================
+ Hits         224165   224583     +418     
+ Misses        67029    66628     -401     
- Partials      18291    18370      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Michael Froh <froh@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

❕ Gradle check result for 9f337cc: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@peterzhuamazon peterzhuamazon merged commit 5938bc8 into opensearch-project:main Apr 11, 2025
30 of 31 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Performance Roadmap Apr 11, 2025
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Apr 15, 2025
* Adding approximate match all query

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Minor refactor

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix doc field sorting

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix more tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix more tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix backward tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

---------

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Michael Froh <froh@amazon.com>
Co-authored-by: Michael Froh <froh@amazon.com>
Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
* Adding approximate match all query

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Minor refactor

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix doc field sorting

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix more tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix more tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix backward tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

---------

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Michael Froh <froh@amazon.com>
Co-authored-by: Michael Froh <froh@amazon.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
* Adding approximate match all query

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Minor refactor

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix doc field sorting

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix more tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix more tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix backward tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

---------

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Michael Froh <froh@amazon.com>
Co-authored-by: Michael Froh <froh@amazon.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
@harshavamsi harshavamsi deleted the approximate_match_all branch November 25, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request Roadmap:Cost/Performance/Scale Project-wide roadmap label v3.0.0 Issues and PRs related to version 3.0.0

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants