Increase default maxMergeAtOnce from 10 to 30#17774
Merged
sachinpkale merged 6 commits intoopensearch-project:mainfrom Apr 16, 2025
Merged
Increase default maxMergeAtOnce from 10 to 30#17774sachinpkale merged 6 commits intoopensearch-project:mainfrom
sachinpkale merged 6 commits intoopensearch-project:mainfrom
Conversation
Contributor
|
❌ Gradle check result for 97aef8a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
linuxpi
force-pushed
the
max-merge-at-once
branch
from
97aef8a to
4709b11
Compare
Contributor
|
❌ Gradle check result for 4709b11: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
linuxpi
force-pushed
the
max-merge-at-once
branch
3 times, most recently
from
9fe9c14 to
f37545f
Compare
github-actions
bot
added
enhancement
Contributor
|
❌ Gradle check result for f37545f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
linuxpi
force-pushed
the
max-merge-at-once
branch
from
f37545f to
70a31d9
Compare
Contributor
|
❌ Gradle check result for 70a31d9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Author
Test Result (2 failures / -1) |
linuxpi
force-pushed
the
max-merge-at-once
branch
from
f4e8a91 to
42b4bcf
Compare
linuxpi
requested review from
Bukhtawar,
CEHENKLE,
anasalkouz,
andrross,
ashking94,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19 and
reta
as code owners
Collaborator
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/59/
|
Signed-off-by: Varun Bansal <bansvaru@amazon.com>
Contributor
|
❌ Gradle check result for fb43f2f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Author
|
{"run-benchmark-test": "id_5"} |
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2832/ . Final results will be published once the job is completed. |
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/2832/
|
Collaborator
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/64/
|
This was referenced Apr 14, 2025
Signed-off-by: Varun Bansal <bansvaru@amazon.com>
Contributor
|
❌ Gradle check result for 9d5c6b5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
sachinpkale
approved these changes
Apr 16, 2025
Lindsay-00
pushed a commit
to Lindsay-00/OpenSearch
that referenced
this pull request
Apr 22, 2025
* Increase default maxMergeAtOnce from 10 to 30 Signed-off-by: Varun Bansal <bansvaru@amazon.com> * add changelog entry Signed-off-by: Varun Bansal <bansvaru@amazon.com> * Handle the cases when index setting are removed and added Signed-off-by: Varun Bansal <bansvaru@amazon.com> * Improve logging Signed-off-by: Varun Bansal <bansvaru@amazon.com> --------- Signed-off-by: Varun Bansal <bansvaru@amazon.com> Signed-off-by: Lingxi Chen <lingxich@amazon.com>
Lindsay-00
pushed a commit
to Lindsay-00/OpenSearch
that referenced
this pull request
Apr 22, 2025
* Increase default maxMergeAtOnce from 10 to 30 Signed-off-by: Varun Bansal <bansvaru@amazon.com> * add changelog entry Signed-off-by: Varun Bansal <bansvaru@amazon.com> * Handle the cases when index setting are removed and added Signed-off-by: Varun Bansal <bansvaru@amazon.com> * Improve logging Signed-off-by: Varun Bansal <bansvaru@amazon.com> --------- Signed-off-by: Varun Bansal <bansvaru@amazon.com> Signed-off-by: Lingxi Chen <lingxich@amazon.com>
x-INFiN1TY-x
pushed a commit
to x-INFiN1TY-x/OpenSearch_Local
that referenced
this pull request
Apr 24, 2025
* Increase default maxMergeAtOnce from 10 to 30 Signed-off-by: Varun Bansal <bansvaru@amazon.com> * add changelog entry Signed-off-by: Varun Bansal <bansvaru@amazon.com> * Handle the cases when index setting are removed and added Signed-off-by: Varun Bansal <bansvaru@amazon.com> * Improve logging Signed-off-by: Varun Bansal <bansvaru@amazon.com> --------- Signed-off-by: Varun Bansal <bansvaru@amazon.com> Signed-off-by: Tanishq Ranjan <tqranjan@amazon.com>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
* Increase default maxMergeAtOnce from 10 to 30 Signed-off-by: Varun Bansal <bansvaru@amazon.com> * add changelog entry Signed-off-by: Varun Bansal <bansvaru@amazon.com> * Handle the cases when index setting are removed and added Signed-off-by: Varun Bansal <bansvaru@amazon.com> * Improve logging Signed-off-by: Varun Bansal <bansvaru@amazon.com> --------- Signed-off-by: Varun Bansal <bansvaru@amazon.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
* Increase default maxMergeAtOnce from 10 to 30 Signed-off-by: Varun Bansal <bansvaru@amazon.com> * add changelog entry Signed-off-by: Varun Bansal <bansvaru@amazon.com> * Handle the cases when index setting are removed and added Signed-off-by: Varun Bansal <bansvaru@amazon.com> * Improve logging Signed-off-by: Varun Bansal <bansvaru@amazon.com> --------- Signed-off-by: Varun Bansal <bansvaru@amazon.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Contributor
|
@linuxpi, @sachinpkale I am trying to understand the change and the default choose for this change. In the benchmarks I don't see which metrics improved which let us believe that we should have gone with these aggressive defaults. Benchmarks I am seeing are here: #17774 (comment) Can you please point me to benchmarks/comment where we saw the improvements which let us encourage to go with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Resolves #17051
Check List
[ ] API changes companion pull request created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.