Fix socket interceptor and add unit test#17784
Fix socket interceptor and add unit test#17784andrross merged 1 commit intoopensearch-project:mainfrom
Conversation
The optimization of using a Stream instead of a Collection caused problems with class not found and/or illegal access errors when using the lambda function in the `Stream::forEach` call in the intercept method. Signed-off-by: Andrew Ross <andrross@amazon.com>
|
Thanks @andrross , was about to send the fix as well |
libs/agent-sm/agent/src/main/java/org/opensearch/javaagent/SocketChannelInterceptor.java
Show resolved
Hide resolved
libs/agent-sm/agent/src/test/java/org/opensearch/javaagent/AgentTestCase.java
Show resolved
Hide resolved
|
❌ Gradle check result for 0c0a349: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 0c0a349: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 0c0a349: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17784 +/- ##
============================================
+ Coverage 72.32% 72.35% +0.03%
+ Complexity 66005 65987 -18
============================================
Files 5356 5358 +2
Lines 306446 306485 +39
Branches 44395 44406 +11
============================================
+ Hits 221634 221768 +134
+ Misses 66660 66543 -117
- Partials 18152 18174 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The optimization of using a Stream instead of a Collection caused problems with class not found and/or illegal access errors when using the lambda function in the
Stream::forEachcall in the intercept method.FYI @RajatGupta02
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.