Skip to content

Add some additional tests for SocketChannelInterceptor#17798

Merged
reta merged 2 commits intoopensearch-project:mainfrom
RajatGupta02:socket-channel-test-branch
Apr 4, 2025
Merged

Add some additional tests for SocketChannelInterceptor#17798
reta merged 2 commits intoopensearch-project:mainfrom
RajatGupta02:socket-channel-test-branch

Conversation

@RajatGupta02
Copy link
Copy Markdown
Contributor

Description

Adds some additional tests for Socket Channel Interceptor

Related Issues

Resolves #17664

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rajat Gupta <gptrajat@amazon.com>
@RajatGupta02
Copy link
Copy Markdown
Contributor Author

RajatGupta02 commented Apr 4, 2025

Added some additional tests cc: @andrross ,
Thanks

Signed-off-by: Rajat Gupta <gptrajat@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2025

❕ Gradle check result for cd012b9: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.40%. Comparing base (5ec96c5) to head (cd012b9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17798      +/-   ##
============================================
+ Coverage     72.35%   72.40%   +0.05%     
- Complexity    66054    66074      +20     
============================================
  Files          5358     5358              
  Lines        306485   306485              
  Branches      44406    44406              
============================================
+ Hits         221763   221924     +161     
+ Misses        66538    66453      -85     
+ Partials      18184    18108      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reta reta merged commit 94da0df into opensearch-project:main Apr 4, 2025
34 of 35 checks passed
@RajatGupta02 RajatGupta02 deleted the socket-channel-test-branch branch April 30, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request security Anything security related skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Integration Test for SocketInterceptor

2 participants