Skip to content

Added Search Only strict routing setting#17803

Merged
mch2 merged 4 commits intoopensearch-project:mainfrom
vinaykpud:rw/search-routing
Apr 8, 2025
Merged

Added Search Only strict routing setting#17803
mch2 merged 4 commits intoopensearch-project:mainfrom
vinaykpud:rw/search-routing

Conversation

@vinaykpud
Copy link
Copy Markdown
Contributor

@vinaykpud vinaykpud commented Apr 5, 2025

Description

Setting cluster.routing.search_only.strict

By default value of this setting will be true and its applicable only if the search replicas exist for an index ie index.number_of_search_only_replicas for an index is greater than 0.

If the search replicas exists for an index by default _search requests will be routed to search replicas. But when we have search replicas value of cluster.routing.search_only.strict setting can made false so that _search requests can land on any available shard.

Related Issues

Resolves #17424
Related #15306

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
@github-actions github-actions bot added the bug Something isn't working label Apr 5, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2025

❌ Gradle check result for 48f1dbc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2025

✅ Gradle check result for 48f1dbc: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.24%. Comparing base (c91cdcb) to head (033c4c2).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...g/opensearch/cluster/routing/OperationRouting.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17803      +/-   ##
============================================
- Coverage     72.46%   72.24%   -0.22%     
+ Complexity    66502    66403      -99     
============================================
  Files          5408     5408              
  Lines        308080   308160      +80     
  Branches      44720    44736      +16     
============================================
- Hits         223239   222622     -617     
- Misses        66536    67342     +806     
+ Partials      18305    18196     -109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Performance Roadmap Apr 7, 2025
Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2025

✅ Gradle check result for b849131: SUCCESS

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2025

❌ Gradle check result for 033c4c2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@vinaykpud vinaykpud closed this Apr 8, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Performance Roadmap Apr 8, 2025
@vinaykpud vinaykpud reopened this Apr 8, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Performance Roadmap Apr 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2025

✅ Gradle check result for 033c4c2: SUCCESS

@mch2 mch2 merged commit ca03fdd into opensearch-project:main Apr 8, 2025
57 of 59 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Performance Roadmap Apr 8, 2025
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
* Added Search Only strict routing setting

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>

* Added Changelog

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>

---------

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
* Added Search Only strict routing setting

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>

* Added Changelog

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>

---------

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[RW Separation] Block Search Requests when All Search-Only Replicas are unassigned, with proper response

3 participants