Fix possible NPE in WorkerBulkByScrollTaskState.java#17840
Merged
andrross merged 1 commit intoopensearch-project:mainfrom Apr 8, 2025
Merged
Conversation
Signed-off-by: Ilmar S. Habibulin <161701313+ngr-ilmarh@users.noreply.github.com>
ngr-ilmarh
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
|
❌ Gradle check result for 54e914a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
andrross
approved these changes
Apr 8, 2025
owaiskazi19
approved these changes
Apr 8, 2025
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17840 +/- ##
=========================================
Coverage 72.35% 72.36%
- Complexity 66054 66105 +51
=========================================
Files 5358 5358
Lines 306485 306485
Branches 44406 44406
=========================================
+ Hits 221763 221793 +30
- Misses 66538 66606 +68
+ Partials 18184 18086 -98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ngr-ilmarh
deleted the
Fix-#17839-NPE-in-WorkerBulkByScrollTaskState.java
branch
This was referenced Apr 14, 2025
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
Signed-off-by: Ilmar S. Habibulin <161701313+ngr-ilmarh@users.noreply.github.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
Signed-off-by: Ilmar S. Habibulin <161701313+ngr-ilmarh@users.noreply.github.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix possible NPE in rethrottling requests.
No tests were run, i think this is useless here
Related Issues
Resolves #17839
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.