Skip to content

[Pull-based ingestion] make maxPollSize and pollTimeout in IngestionSource configurable#17863

Merged
mch2 merged 3 commits intoopensearch-project:mainfrom
yupeng9:configParam
Apr 9, 2025
Merged

[Pull-based ingestion] make maxPollSize and pollTimeout in IngestionSource configurable#17863
mch2 merged 3 commits intoopensearch-project:mainfrom
yupeng9:configParam

Conversation

@yupeng9
Copy link
Copy Markdown
Contributor

@yupeng9 yupeng9 commented Apr 9, 2025

Description

Allow maxPollSize and pollTimeout in IngestionSource to be configurable

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2025

✅ Gradle check result for f11fd9c: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.49%. Comparing base (7b6108b) to head (51dfaf8).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...g/opensearch/cluster/metadata/IngestionSource.java 80.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17863      +/-   ##
============================================
+ Coverage     72.44%   72.49%   +0.05%     
- Complexity    66483    66545      +62     
============================================
  Files          5409     5409              
  Lines        308282   308276       -6     
  Branches      44759    44750       -9     
============================================
+ Hits         223344   223494     +150     
+ Misses        66608    66541      -67     
+ Partials      18330    18241      -89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Yupeng Fu <yupeng@uber.com>
yupeng9 added 2 commits April 9, 2025 13:18
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Yupeng Fu <yupeng@uber.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2025

❕ Gradle check result for 51dfaf8: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@mch2 mch2 merged commit 9035f50 into opensearch-project:main Apr 9, 2025
31 checks passed
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Apr 15, 2025
…ource configurable (opensearch-project#17863)

* make maxPollSize and pollTimeout in IngestionSource configurable

Signed-off-by: Yupeng Fu <yupeng@uber.com>

* changelog

Signed-off-by: Yupeng Fu <yupeng@uber.com>

* comment

Signed-off-by: Yupeng Fu <yupeng@uber.com>

---------

Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…ource configurable (opensearch-project#17863)

* make maxPollSize and pollTimeout in IngestionSource configurable

Signed-off-by: Yupeng Fu <yupeng@uber.com>

* changelog

Signed-off-by: Yupeng Fu <yupeng@uber.com>

* comment

Signed-off-by: Yupeng Fu <yupeng@uber.com>

---------

Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…ource configurable (opensearch-project#17863)

* make maxPollSize and pollTimeout in IngestionSource configurable

Signed-off-by: Yupeng Fu <yupeng@uber.com>

* changelog

Signed-off-by: Yupeng Fu <yupeng@uber.com>

* comment

Signed-off-by: Yupeng Fu <yupeng@uber.com>

---------

Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants