Skip to content

Allow to get the search request from the QueryCoordinatorContext#17890

Merged
saratvemulapalli merged 2 commits intoopensearch-project:mainfrom
bzhangam:query
May 1, 2025
Merged

Allow to get the search request from the QueryCoordinatorContext#17890
saratvemulapalli merged 2 commits intoopensearch-project:mainfrom
bzhangam:query

Conversation

@bzhangam
Copy link
Copy Markdown
Contributor

Description

Add target indices info to the QueryCoordinatorContext.

Related Issues

This is needed to support a new feature in neural plugin: #[1211]

In the new feature when we rewrite the query on coordinator node we need to know the target indices to decide how to do the rewrite based on the index configuration.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 05b2bab: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for e53dbb2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 85a1eca: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bzhangam bzhangam closed this Apr 29, 2025
@bzhangam bzhangam reopened this Apr 29, 2025
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for c1c3747: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for c1c3747: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 09e233f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 1174f4c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 25c11d6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bzhangam bzhangam closed this Apr 30, 2025
@bzhangam bzhangam reopened this Apr 30, 2025
@bzhangam bzhangam requested a review from a team as a code owner April 30, 2025 22:30
@bzhangam bzhangam changed the title Add target indices info to the QueryCoordinatorContext Allow to get the search request from the QueryCoordinatorContext Apr 30, 2025
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for b142c4d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 1, 2025

✅ Gradle check result for 15c3f9a: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.56%. Comparing base (00abaac) to head (3ca4787).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...nsearch/action/explain/TransportExplainAction.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17890      +/-   ##
============================================
- Coverage     72.58%   72.56%   -0.02%     
- Complexity    67219    67258      +39     
============================================
  Files          5476     5476              
  Lines        310445   310445              
  Branches      45121    45121              
============================================
- Hits         225324   225269      -55     
- Misses        66780    66879      +99     
+ Partials      18341    18297      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Bo Zhang <bzhangam@amazon.com>
@bzhangam bzhangam closed this May 1, 2025
@bzhangam bzhangam reopened this May 1, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 1, 2025

❕ Gradle check result for 3ca4787: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants