Skip to content

Visit the subquery builder recursively #17953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jainankitk merged 2 commits into from
Apr 22, 2025
Merged

Visit the subquery builder recursively #17953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc79a23
visit the subquery
vibrantvarun Apr 15, 2025
2087542
Fix visit method of constant score query and function score query to …
vibrantvarun Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server/src/main/java/org/opensearch/index/query/ConstantScoreQueryBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,9 @@ protected void extractInnerHitBuilders(Map<String, InnerHitContextBuilder> inner
@Override
public void visit(QueryBuilderVisitor visitor) {
visitor.accept(this);
visitor.getChildVisitor(BooleanClause.Occur.FILTER).accept(filterBuilder);
if (filterBuilder != null) {
filterBuilder.visit(visitor.getChildVisitor(BooleanClause.Occur.FILTER));
}
}

}
2 changes: 1 addition & 1 deletion server/src/main/java/org/opensearch/index/query/DisMaxQueryBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ public void visit(QueryBuilderVisitor visitor) {
if (queries.isEmpty() == false) {
QueryBuilderVisitor subVisitor = visitor.getChildVisitor(BooleanClause.Occur.SHOULD);
for (QueryBuilder subQb : queries) {
subVisitor.accept(subQb);
subQb.visit(subVisitor);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/org/opensearch/index/query/functionscore/FunctionScoreQueryBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@ private static String parseFiltersAndFunctions(
public void visit(QueryBuilderVisitor visitor) {
visitor.accept(this);
if (query != null) {
visitor.getChildVisitor(BooleanClause.Occur.MUST).accept(query);
query.visit(visitor.getChildVisitor(BooleanClause.Occur.MUST));
}
}
}
Loading