Disable approximation when there is terminate after

[harshavamsi]

Description

We're disabling approximation when there is terminate after. We need to explicitly handle this case in the custom collector. Will raise a PR to do that later.

Related Issues

Resolves #16851

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for f9af5f7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[andrross]

@harshavamsi What's the status here? Is this attempting to fix #16851?

[github-actions]

✅ Gradle check result for f9af5f7: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.54%. Comparing base (96481cc) to head (f9af5f7).
Report is 26 commits behind head on main.

Files with missing lines	Patch %	Lines
...search/approximate/ApproximatePointRangeQuery.java	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #18018      +/-   ##
============================================
- Coverage     72.59%   72.54%   -0.06%     
+ Complexity    67172    67125      -47     
============================================
  Files          5478     5478              
  Lines        310125   310126       +1     
  Branches      45080    45081       +1     
============================================
- Hits         225135   224977     -158     
- Misses        66676    66836     +160     
+ Partials      18314    18313       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[andrross]

@harshavamsi Are we missing something in the ApproximatePointRangeQueryTests unit test that could have caught this?

[harshavamsi]

@harshavamsi Are we missing something in the ApproximatePointRangeQueryTests unit test that could have caught this?

I don't think we could have caught this issue there. We never added the check for terminate_after in the approximation itself. I will raise an issue to add support for this later.