Skip to content

Update JavaVersionChecker to enforce min of JDK21#18034

Merged
reta merged 1 commit intoopensearch-project:mainfrom
andrross:java-version-checker-21
Apr 22, 2025
Merged

Update JavaVersionChecker to enforce min of JDK21#18034
reta merged 1 commit intoopensearch-project:mainfrom
andrross:java-version-checker-21

Conversation

@andrross
Copy link
Copy Markdown
Member

@andrross andrross commented Apr 22, 2025

Manually tested this:

% JAVA_HOME=~/.sdkman/candidates/java/11.0.27-tem ./bin/opensearch
OpenJDK 64-Bit Server VM warning: Shared spaces are not supported in this VM
OpenSearch requires Java 21; your Java version from [/Users/andrross/.sdkman/candidates/java/11.0.27-tem] does not meet this requirement

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andrew Ross <andrross@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for aa9cdb9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for aa9cdb9: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.59%. Comparing base (6afec2a) to head (aa9cdb9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...tools/java_version_checker/JavaVersionChecker.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18034      +/-   ##
============================================
+ Coverage     72.57%   72.59%   +0.02%     
- Complexity    67160    67179      +19     
============================================
  Files          5478     5478              
  Lines        310130   310130              
  Branches      45087    45087              
============================================
+ Hits         225068   225145      +77     
+ Misses        66661    66604      -57     
+ Partials      18401    18381      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reta reta merged commit d907511 into opensearch-project:main Apr 22, 2025
61 of 63 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 22, 2025
Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit d907511)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
x-INFiN1TY-x pushed a commit to x-INFiN1TY-x/OpenSearch_Local that referenced this pull request Apr 24, 2025
…#18034)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Tanishq Ranjan <tqranjan@amazon.com>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…#18034)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…#18034)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants