[Backport 3.0] [rule based autotagging] Add Get Rule API Logic#18055
[Backport 3.0] [rule based autotagging] Add Get Rule API Logic#18055opensearch-trigger-bot[bot] wants to merge 1 commit into3.0from
Conversation
* add get rule api logic Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * rebase from main after the schema merged Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * extract common logics to libs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * Add javadocs for libs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * correct UT Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> r * refactor code and fix ut Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove commented code Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address comments Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * change method name Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix merge conflicts Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rename queryGroup to workloadGroup Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add guice binding related changes Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * refactor code to create a generic rule framework structure Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix javadoc Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * fix UT Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * restructure tests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rebase with mainline Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix gradlew file Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add UT Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add action UTs Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * correct the comment Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add more UT Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Co-authored-by: Kaushal Kumar <ravi.kaushal97@gmail.com> (cherry picked from commit 8932876) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
left a comment
There was a problem hiding this comment.
The 3.0 beta was the cutoff for new features, so I think we'll want to be pretty selective about what we merge into 3.0 at this point to ensure a stable release. This looks to me like much more of a new feature rather than a fix for a bug or performance issue. Is this critical to bring into 3.0 or can it be deferred until 3.1?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.0 #18055 +/- ##
======================================
Coverage ? 72.58%
Complexity ? 67152
======================================
Files ? 5473
Lines ? 309913
Branches ? 45025
======================================
Hits ? 224961
Misses ? 66597
Partials ? 18355 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks @andrross for bringing this up. While some of it is new feature, this PR has refactoring for moving autotagging logic into modules, which is the right place IMO. Hence, I would like to get this in to ensure we don't pollute core with stuff that is not needed! |
@jainankitk This commit contains mostly new files.
I think you've accomplished that goal by committing this change to main. Why does this need to be backported into the release? |
|
This change should not be a breaking change since core functionality is still dorment (It is behind a plugin). Given we want to introduce the auto-tagging feature starting 3.0, I think it should be fine to put this in 3.0. |
I was hoping to make this change eagerly, but if you don't see any concerns with this happening in 3.1 instead of 3.0, I am fine with that. |
Backport 8932876 from #17336.