Skip to content

[Backport 3.0] Visit the subquery builder recursively#18063

Merged
jainankitk merged 1 commit into3.0from
backport/backport-17953-to-3.0
Apr 24, 2025
Merged

[Backport 3.0] Visit the subquery builder recursively#18063
jainankitk merged 1 commit into3.0from
backport/backport-17953-to-3.0

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Apr 23, 2025

Backport b9046eb from #17953.

@github-actions
Visit the subquery builder recursively (#17953)
daf08c7 
* visit the subquery

Signed-off-by: Varun Jain <varunudr@amazon.com>

* Fix visit method of constant score query and function score query to iterate recursively

Signed-off-by: Varun Jain <varunudr@amazon.com>

---------

Signed-off-by: Varun Jain <varunudr@amazon.com>
(cherry picked from commit b9046eb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 23, 2025

❌ Gradle check result for daf08c7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Apr 23, 2025
Closed
Open
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 24, 2025

❌ Gradle check result for daf08c7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 24, 2025

❌ Gradle check result for daf08c7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Apr 23, 2025
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Apr 24, 2025
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 24, 2025

✅ Gradle check result for daf08c7: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (3.0@59a6efd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...nsearch/index/query/ConstantScoreQueryBuilder.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##             3.0   #18063   +/-   ##
======================================
  Coverage       ?   72.54%           
  Complexity     ?    67097           
======================================
  Files          ?     5478           
  Lines          ?   310025           
  Branches       ?    45066           
======================================
  Hits           ?   224905           
  Misses         ?    66771           
  Partials       ?    18349

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jainankitk jainankitk merged commit 661f665 into 3.0 Apr 24, 2025
55 of 56 checks passed
@github-actions github-actions bot deleted the backport/backport-17953-to-3.0 branch April 24, 2025 16:26
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Apr 24, 2025
Open
prudhvigodithi pushed a commit to prudhvigodithi/OpenSearch that referenced this pull request May 6, 2025
@opensearch-trigger-bot @github-actions @prudhvigodithi
Visit the subquery builder recursively (opensearch-project#17953) (op…
6572e9c 
…ensearch-project#18063)

* visit the subquery

* Fix visit method of constant score query and function score query to iterate recursively

---------

(cherry picked from commit b9046eb)

Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jainankitk jainankitk jainankitk approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jainankitk