Fix testAddReplicaWhileWritesBlocked test under SegmentReplicationWithRemoteStorePressureIT#18067
Conversation
shourya035
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
cwperks,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
|
@shourya035 without this change, how soon does the test fails? |
...rc/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationBaseIT.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for a1830f3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
With 1 minute wait on |
|
❌ Gradle check result for a1830f3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18067 +/- ##
============================================
- Coverage 72.53% 72.51% -0.03%
- Complexity 67132 67155 +23
============================================
Files 5474 5474
Lines 310173 310174 +1
Branches 45066 45066
============================================
- Hits 224993 224916 -77
- Misses 66840 66856 +16
- Partials 18340 18402 +62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Description
Fix for
SegmentReplicationWithRemoteStorePressureIT#testAddReplicaWhileWritesBlocked. Test was failing at around 3000 iterations with primary and replica doc count mismatch.Increased assertBusy check to 2 minutes from 1 minutes. After this change, test has been running for over 8000 iterations without failing.
Related Issues
Resolves #[14330]
Check List
[ ] Functionality includes testing.[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.