Add support for matched_fields with the unified highlighter

[nomoa]

Description

This option was silently ignored when running the unified highlighter. Since lucene 10 it is now possible to pass a list of additional fields to fetch matches from and blend into the snippets.

Related Issues

Resolves #18164

Check List

• Functionality includes testing.
• [ ] API changes companion pull request created, if applicable.
• Public documentation issue/PR: Document that the unified highlighter supports matched_field documentation-website#9793

[github-actions]

❌ Gradle check result for e9a0a85: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for ad13011: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for fa503d1: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.47%. Comparing base (93d5356) to head (dcd711a).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...h/fetch/subphase/highlight/UnifiedHighlighter.java	63.63%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #18166      +/-   ##
============================================
- Coverage     72.57%   72.47%   -0.11%     
+ Complexity    67446    67325     -121     
============================================
  Files          5488     5488              
  Lines        311069   311067       -2     
  Branches      45217    45218       +1     
============================================
- Hits         225757   225431     -326     
- Misses        66986    67229     +243     
- Partials      18326    18407      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[msfroh]

This looks great! Thanks a lot @nomoa!

[nomoa]

is the code coverage check being green mandatory? The code is being tested in integration tests but if you prefer I can introduce a dedicated test for these lines (might need to make some methods visible for testing, unless there are some facilities to easily create/mock FieldHighlightContext)

[github-actions]

❌ Gradle check result for 4d6a2ae: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for 09717f8: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

❌ Gradle check result for 95d48bb: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for dcd711a: SUCCESS

[nomoa]

@andrross @msfroh thanks for the reviews! Is there anything I can do to help get this PR merged?

[msfroh]

@andrross @msfroh thanks for the reviews! Is there anything I can do to help get this PR merged?

One of the automated checks "Validate Gradle Wrapper" had failed with a timeout. I just retried it and it looks good now. 👍

Thanks @nomoa!