Add tolerance for matrix stats agg variance value assertion#18212
Merged
andrross merged 1 commit intoopensearch-project:mainfrom May 8, 2025
Merged
Add tolerance for matrix stats agg variance value assertion#18212andrross merged 1 commit intoopensearch-project:mainfrom
andrross merged 1 commit intoopensearch-project:mainfrom
Conversation
github-actions
bot
added
>test-failure
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18212 +/- ##
============================================
+ Coverage 72.52% 72.55% +0.02%
- Complexity 67228 67320 +92
============================================
Files 5476 5476
Lines 310470 310470
Branches 45131 45131
============================================
+ Hits 225168 225247 +79
+ Misses 66973 66912 -61
+ Partials 18329 18311 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbwiddis
reviewed
May 6, 2025
client/rest-high-level/src/test/java/org/opensearch/client/SearchIT.java
Show resolved
Hide resolved
dbwiddis
approved these changes
May 7, 2025
Member
dbwiddis
left a comment
dbwiddis
left a comment
There was a problem hiding this comment.
Approved with reservations. See unresolved comments.
andrross
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After enabling the concurrent segment search by default, the variance result from matrix stats starts to flaky around the asserting value a little bit which seems coming from precision loss of float data.
The parallel search and randomness of segment layout are considered to be the cause of this flaky.
A quick look into how variance is calculated and a conversation with AI say "floating-point arithmetic not being perfectly associative", (A + B) + (C + D)
slices groupmay not be same as A + B + C + Ddefault sequential segment. Seem reasonable to me.Tolerance is choosed based on the failed tests. Mismatch happens at the last digit
0.0000000000002
So choose
0.000000000001 to be the tolerance.
Related Issues
Resolves #18129
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.