Fix incorrect constructor param ordering in ShardRouting#18248
Merged
Conversation
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Contributor
|
❌ Gradle check result for cc875c6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
msfroh
approved these changes
May 9, 2025
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18248 +/- ##
============================================
- Coverage 72.66% 72.55% -0.12%
+ Complexity 67404 67298 -106
============================================
Files 5483 5483
Lines 310776 310772 -4
Branches 45176 45174 -2
============================================
- Hits 225814 225467 -347
- Misses 66614 66919 +305
- Partials 18348 18386 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…project#18248) Signed-off-by: Marc Handalian <marc.handalian@gmail.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…project#18248) Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default ctor for ShardRouting has currentNodeId before relocatingNodeId. A new ctor to add support for the search only flag was added with this order swapped. There is no actual bug surfaced because it then passes the relocating as the current. Further there is only one caller of this ctor here, that passes the current as the relocated... anyway this cleans it up.
Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.