Apply cluster state metadata and routing table diff when building clu…

[SwethaGuptha]

…ster state from remote

Description

As part of this change the diff remote state download will handle the deleted indices metadata and routing table before building the updated cluster state from the entities read from the remote. Without this, request to create alias with name same as the index being deleted in the same request fails due to error java.lang.IllegalStateException: index, alias, and data stream names need to be unique, but the following duplicates were found [index-2 (alias of [index-1/cf4980a322bac991a0ee6]) conflicts with index] in diff download flow.

Related Issues

Resolves #18045

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 5a3a33c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for dbf86de: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[shiv0408]

Looks good!

[github-actions]

✅ Gradle check result for 4b4b81d: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.51%. Comparing base (998ae73) to head (c71a586).

Files with missing lines	Patch %	Lines
...arch/gateway/remote/RemoteClusterStateService.java	56.00%	7 Missing and 4 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #18256      +/-   ##
============================================
+ Coverage     72.48%   72.51%   +0.02%     
- Complexity    67357    67364       +7     
============================================
  Files          5488     5488              
  Lines        311023   311030       +7     
  Branches      45217    45216       -1     
============================================
+ Hits         225444   225534      +90     
+ Misses        67282    67107     -175     
- Partials      18297    18389      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

❕ Gradle check result for c71a586: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[SwethaGuptha]

❕ Gradle check result for c71a586: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Flaky test #14299