Composite Directory - silently fail instead of throwing error for non-existent file in deleteFile() call#18299
Merged
gbbafna merged 1 commit intoopensearch-project:mainfrom May 15, 2025
Conversation
Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
Contributor
|
❕ Gradle check result for 75db1d3: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18299 +/- ##
============================================
+ Coverage 72.44% 72.53% +0.09%
- Complexity 67256 67387 +131
============================================
Files 5488 5488
Lines 310994 311004 +10
Branches 45212 45213 +1
============================================
+ Hits 225288 225595 +307
+ Misses 67297 67067 -230
+ Partials 18409 18342 -67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gbbafna
approved these changes
May 15, 2025
tanik98
pushed a commit
to tanik98/OpenSearch
that referenced
this pull request
May 27, 2025
…ory (opensearch-project#18299) Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Jun 1, 2025
…ory (opensearch-project#18299) Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
rayshrey
added a commit
to rayshrey/OpenSearch
that referenced
this pull request
Jun 26, 2025
…ory (opensearch-project#18299) Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…ory (opensearch-project#18299) Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…ory (opensearch-project#18299) Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In composite directory for deleteFile method, we currently throw a NoSuchFileException if the file is not found in the directory.
In this PR we are adding a modification that instead of throwing a NoSuchFileException we simply fail silently.
This is needed because we can run into scenarios where stale files are evicted locally (zero refCount in FileCache) and not present in remote as well (due to metadata refresh). In such scenarios listAll() of composite directory will not show the file and operations such as refresh/merge where we calling this deleteFile method will fail.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.