Skip to content

[Backport 1.x] Bouncycastle upgrade 1.x#1834

Merged
saratvemulapalli merged 1 commit intoopensearch-project:1.xfrom
saratvemulapalli:bouncycastle-upgrade-1.x
Jan 4, 2022
Merged

[Backport 1.x] Bouncycastle upgrade 1.x#1834
saratvemulapalli merged 1 commit intoopensearch-project:1.xfrom
saratvemulapalli:bouncycastle-upgrade-1.x

Conversation

@saratvemulapalli
Copy link
Copy Markdown
Member

@saratvemulapalli saratvemulapalli commented Jan 3, 2022 •
edited
Loading

Description

Backport #1832 to 1.x

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

opensearch-ci-bot commented Jan 3, 2022

Can one of the admins verify this patch?

@saratvemulapalli
Upgrading bouncycastle to 1.70 (#1832)
bc60e30 
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

opensearch-ci-bot commented Jan 3, 2022

✅   Gradle Check success b42dec183ed7a0cd75252d1c2164f741caf05019
Log 1751

Reports 1751

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

opensearch-ci-bot commented Jan 3, 2022

❌   Gradle Check failure bc60e30
Log 1752

Reports 1752

@saratvemulapalli
Copy link
Copy Markdown
Member Author

saratvemulapalli commented Jan 3, 2022

start gradle check

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

opensearch-ci-bot commented Jan 3, 2022

❌   Gradle Check failure bc60e30
Log 1754

Reports 1754

@saratvemulapalli
Copy link
Copy Markdown
Member Author

saratvemulapalli commented Jan 4, 2022 •
edited
Loading

❌   Gradle Check failure bc60e30 Log 1754

Reports 1754

Looks unrelated error to me. I'll give it another shot while reporting this to flaky tests.
Issue: #1844

REPRODUCE WITH: ./gradlew ':plugins:transport-nio:test' --tests "org.opensearch.http.nio.NioHttpServerTransportTests.testLargeCompressedResponse" -Dtests.seed=EA1764D9DE4EEADD -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=no -Dtests.timezone=America/Maceio -Druntime.java=15

org.opensearch.http.nio.NioHttpServerTransportTests > testLargeCompressedResponse FAILED
    com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=183, name=opensearch[transport_worker][T#1], state=RUNNABLE, group=TGRP-NioHttpServerTransportTests]

        Caused by:
        java.lang.AssertionError
            at __randomizedtesting.SeedInfo.seed([EA1764D9DE4EEADD]:0)
            at org.opensearch.http.nio.NioHttpServerTransportTests$3.dispatchRequest(NioHttpServerTransportTests.java:351)

    com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=184, name=opensearch[transport_worker][T#2], state=RUNNABLE, group=TGRP-NioHttpServerTransportTests]

        Caused by:
        java.lang.AssertionError
            at __randomizedtesting.SeedInfo.seed([EA1764D9DE4EEADD]:0)
            at org.opensearch.http.nio.NioHttpServerTransportTests$3.dispatchRequest(NioHttpServerTransportTests.java:351)

@saratvemulapalli
Copy link
Copy Markdown
Member Author

saratvemulapalli commented Jan 4, 2022

start gradle check

@saratvemulapalli
Copy link
Copy Markdown
Member Author

saratvemulapalli commented Jan 4, 2022 •
edited
Loading

❌   Gradle Check failure bc60e30 Log 1752

Reports 1752

#1846

REPRODUCE WITH: ./gradlew ':distribution:tools:upgrade-cli:test' --tests "org.opensearch.upgrade.DetectEsInstallationTaskTests.testTaskExecution" -Dtests.seed=1F6F70AEA6323361 -Dtests.security.manager=false -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ms-MY -Dtests.timezone=America/Araguaina -Druntime.java=15

org.opensearch.upgrade.DetectEsInstallationTaskTests > testTaskExecution FAILED
    java.lang.AssertionError: 
    Expected: a collection with size <0>
         but: collection size was <5>
        at __randomizedtesting.SeedInfo.seed([1F6F70AEA6323361:5575542572657CE4]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:956)
        at org.junit.Assert.assertThat(Assert.java:923)
        at org.opensearch.upgrade.DetectEsInstallationTaskTests.testTaskExecution(DetectEsInstallationTaskTests.java:53)


Suite: Test class org.opensearch.upgrade.DetectEsInstallationTaskTests
  1> [2022-01-03T14:53:51,848][INFO ][o.o.u.DetectEsInstallationTaskTests] [testTaskExecution] before test
  1> [2022-01-03T14:53:53,132][INFO ][o.o.u.DetectEsInstallationTaskTests] [testTaskExecution] after test
  2> REPRODUCE WITH: ./gradlew ':distribution:tools:upgrade-cli:test' --tests "org.opensearch.upgrade.DetectEsInstallationTaskTests.testTaskExecution" -Dtests.seed=1F6F70AEA6323361 -Dtests.security.manager=false -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ms-MY -Dtests.timezone=America/Araguaina -Druntime.java=15
  2> java.lang.AssertionError: 
    Expected: a collection with size <0>
         but: collection size was <5>
        at __randomizedtesting.SeedInfo.seed([1F6F70AEA6323361:5575542572657CE4]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:956)
        at org.junit.Assert.assertThat(Assert.java:923)
        at org.opensearch.upgrade.DetectEsInstallationTaskTests.testTaskExecution(DetectEsInstallationTaskTests.java:53)
  1> [2022-01-03T14:53:53,273][INFO ][o.o.u.DetectEsInstallationTaskTests] [testRetrieveDefaultUrlFromConfig] before test
  1> [2022-01-03T14:53:53,281][INFO ][o.o.u.DetectEsInstallationTaskTests] [testRetrieveDefaultUrlFromConfig] after test
  1> [2022-01-03T14:53:53,304][INFO ][o.o.u.DetectEsInstallationTaskTests] [testRetrieveUrlFromSettings] before test
  1> [2022-01-03T14:53:53,311][INFO ][o.o.u.DetectEsInstallationTaskTests] [testRetrieveUrlFromSettings] after test
  2> NOTE: leaving temporary files on disk at: /var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/distribution/tools/upgrade-cli/build/testrun/test/temp/org.opensearch.upgrade.DetectEsInstallationTaskTests_1F6F70AEA6323361-001
  2> NOTE: test params are: codec=Asserting(Lucene87): {}, docValues:{}, maxPointsInLeafNode=289, maxMBSortInHeap=6.155808444014184, sim=Asserting(RandomSimilarity(queryNorm=false): {}), locale=ms-MY, timezone=America/Araguaina
  2> NOTE: Linux 5.4.0-1045-aws amd64/AdoptOpenJDK 15.0.1 (64-bit)/cpus=72,threads=1,free=401056352,total=536870912
  2> NOTE: All tests run in this JVM: [DetectEsInstallationTaskTests]

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

opensearch-ci-bot commented Jan 4, 2022

❌   Gradle Check failure bc60e30
Log 1766

Reports 1766

@saratvemulapalli saratvemulapalli added >upgrade Label used when upgrading library dependencies (e.g., Lucene) backport PRs or issues specific to backporting features or enhancments backport 1.x labels Jan 4, 2022
@saratvemulapalli
Copy link
Copy Markdown
Member Author

saratvemulapalli commented Jan 4, 2022 •
edited
Loading

❌   Gradle Check failure bc60e30 Log 1766

Reports 1766

Another new failure :/
#1847

REPRODUCE WITH: ./gradlew ':modules:transport-netty4:test' --tests "org.opensearch.http.netty4.Netty4HttpServerTransportTests.testLargeCompressedResponse" -Dtests.seed=49B97FF7A35F7849 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sl -Dtests.timezone=Europe/Uzhgorod -Druntime.java=15

org.opensearch.http.netty4.Netty4HttpServerTransportTests > testLargeCompressedResponse FAILED
    com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=273, name=Thread-5, state=RUNNABLE, group=TGRP-Netty4HttpServerTransportTests]

        Caused by:
        java.lang.AssertionError
            at __randomizedtesting.SeedInfo.seed([49B97FF7A35F7849]:0)
            at org.opensearch.http.netty4.Netty4HttpServerTransportTests$3.dispatchRequest(Netty4HttpServerTransportTests.java:357)

    com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=275, name=Thread-6, state=RUNNABLE, group=TGRP-Netty4HttpServerTransportTests]

        Caused by:
        java.lang.AssertionError
            at __randomizedtesting.SeedInfo.seed([49B97FF7A35F7849]:0)
            at org.opensearch.http.netty4.Netty4HttpServerTransportTests$3.dispatchRequest(Netty4HttpServerTransportTests.java:357)

@saratvemulapalli
Copy link
Copy Markdown
Member Author

saratvemulapalli commented Jan 4, 2022

start gradle check

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

opensearch-ci-bot commented Jan 4, 2022

✅   Gradle Check success bc60e30
Log 1768

Reports 1768

This was referenced Jan 4, 2022
Closed
Closed
@saratvemulapalli saratvemulapalli merged commit 09b74cb into opensearch-project:1.x Jan 4, 2022
@saratvemulapalli saratvemulapalli deleted the bouncycastle-upgrade-1.x branch January 4, 2022 19:57
@saratvemulapalli saratvemulapalli mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@dblock dblock Awaiting requested review from dblock

Assignees

No one assigned

Labels

backport PRs or issues specific to backporting features or enhancments backport 1.x >upgrade Label used when upgrading library dependencies (e.g., Lucene)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saratvemulapalli @opensearch-ci-bot @owaiskazi19