Support/fix for star-tree keyword aggregation dfs mode#18354
Merged
sachinpkale merged 1 commit intoopensearch-project:mainfrom Jun 5, 2025
Merged
Support/fix for star-tree keyword aggregation dfs mode#18354sachinpkale merged 1 commit intoopensearch-project:mainfrom
sachinpkale merged 1 commit intoopensearch-project:mainfrom
Conversation
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18354 +/- ##
============================================
- Coverage 72.53% 72.53% -0.01%
- Complexity 67396 67448 +52
============================================
Files 5492 5492
Lines 311127 311128 +1
Branches 45224 45223 -1
============================================
- Hits 225680 225674 -6
- Misses 67063 67131 +68
+ Partials 18384 18323 -61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sandeshkr419
commented
May 22, 2025
...ava/org/opensearch/search/aggregations/bucket/terms/GlobalOrdinalsStringTermsAggregator.java
Show resolved
Hide resolved
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Contributor
|
❌ Gradle check result for cd9c5be: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
bharath-techie
approved these changes
Jun 4, 2025
Contributor
bharath-techie
left a comment
There was a problem hiding this comment.
Since we are not deferring, can you please raise an issue to do benchmarks ?
Contributor
|
❕ Gradle check result for cd9c5be: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
sachinpkale
approved these changes
Jun 5, 2025
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
…t#18354) Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
…t#18354) Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
abhita
pushed a commit
to abhita/OpenSearch
that referenced
this pull request
Jun 9, 2025
…t#18354) Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…t#18354) Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…t#18354) Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Aug 5, 2025
…t#18354) Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TLDR: DFS flow in keyword terms was returing empty buckets, this PR fixes the flow for DFS case.
Detailed Explanation of Changes:
The existing strategy where we fetch which bucketOrd to update:
For DenseGlobalOrds (used by breadth-first flow) implementation: would return the bucket in for correctly
For RemapGlobalOrds (used by depth-first flow) implementation: was returning
-1when it was trying to find a bucket, and hence bucket was not getting initialized properly with correct values.We needed a new utility to find or create bucket if not available so I have introduced a new utility to resolve the same:
This change ensures that both the cases. bfs/dfs are handled correctly.
Added test cases to handle the same.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.