Skip to content

An attempt to fix flaky ReactorNetty4StreamingStressIT (new failure mode) #18408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rishabhmaurya merged 1 commit into from
Jun 1, 2025
Merged

An attempt to fix flaky ReactorNetty4StreamingStressIT (new failure mode) #18408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions ...ctor-netty4/src/javaRestTest/java/org/opensearch/rest/ReactorNetty4StreamingStressIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import reactor.test.scheduler.VirtualTimeScheduler;

import static org.hamcrest.CoreMatchers.equalTo;
import static org.junit.Assume.assumeThat;

public class ReactorNetty4StreamingStressIT extends OpenSearchRestTestCase {
@After
Expand All @@ -48,12 +49,13 @@ public void tearDown() throws Exception {

@Override
protected Settings restClientSettings() {
return Settings.builder().put(super.restClientSettings()).put(CLIENT_SOCKET_TIMEOUT, "5s").build();
return Settings.builder().put(super.restClientSettings()).put(CLIENT_SOCKET_TIMEOUT, "10s").build();
}

public void testCloseClientStreamingRequest() throws Exception {
final VirtualTimeScheduler scheduler = VirtualTimeScheduler.create(true);
assumeThat("The OpenSearch is not ready", isServiceReady(), equalTo(true));

final VirtualTimeScheduler scheduler = VirtualTimeScheduler.create(true);
final AtomicInteger id = new AtomicInteger(0);
final Stream<String> stream = Stream.generate(
() -> "{ \"index\": { \"_index\": \"test-stress-streaming\", \"_id\": \""
Expand All @@ -74,7 +76,7 @@ public void testCloseClientStreamingRequest() throws Exception {
scheduler.advanceTimeBy(delay); /* emit first element */

StepVerifier.create(
Flux.from(streamingResponse.getBody()).timeout(Duration.ofSeconds(5)).map(b -> new String(b.array(), StandardCharsets.UTF_8))
Flux.from(streamingResponse.getBody()).timeout(Duration.ofSeconds(10)).map(b -> new String(b.array(), StandardCharsets.UTF_8))
).expectNextMatches(s -> s.contains("\"result\":\"created\"") && s.contains("\"_id\":\"1\"")).then(() -> {
try {
client().close();
Expand All @@ -88,4 +90,14 @@ public void testCloseClientStreamingRequest() throws Exception {
)
.verify(Duration.ofSeconds(10));
}

private boolean isServiceReady() {
try {
final Response reponse = client().performRequest(new Request("GET", "/"));
return reponse.getStatusLine().getStatusCode() == 200;
} catch (final IOException ex) {
return false;
}
}

}
Loading