Update FipsMode check to catch NoSuchMethodError#18427
Merged
cwperks merged 2 commits intoopensearch-project:mainfrom Jun 4, 2025
Merged
Update FipsMode check to catch NoSuchMethodError#18427cwperks merged 2 commits intoopensearch-project:mainfrom
cwperks merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
reta
approved these changes
Jun 3, 2025
nagarajg17
approved these changes
Jun 3, 2025
Contributor
|
❌ Gradle check result for 423fb1c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18427 +/- ##
============================================
- Coverage 72.74% 72.64% -0.10%
Complexity 67767 67767
============================================
Files 5497 5504 +7
Lines 311815 311926 +111
Branches 45261 45286 +25
============================================
- Hits 226822 226591 -231
- Misses 66504 66848 +344
+ Partials 18489 18487 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Jun 9, 2025
abhita
pushed a commit
to abhita/OpenSearch
that referenced
this pull request
Jun 9, 2025
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…18427) Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Aug 5, 2025
This was referenced Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an error seen in the security plugin here: https://github.com/opensearch-project/security/actions/runs/15408478290/job/43355642640?pr=5370
The error is really a timing issue as the security plugin has not yet converted to BCFIPS jars because of incompatibility with OpenSAML which is a library used for SAML authentication.
The existing check has a catch block for NoSuchClassDef, but in the case of the security plugin the class exists, but the method does not.
Related Issues
Resolves https://github.com/opensearch-project/security/actions/runs/15408478290/job/43355642640?pr=5370
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.