Minor fixes in WarmDiskThresholdDecider#18456
Merged
gbbafna merged 4 commits intoopensearch-project:mainfrom Jun 10, 2025
Merged
Minor fixes in WarmDiskThresholdDecider#18456gbbafna merged 4 commits intoopensearch-project:mainfrom
gbbafna merged 4 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
skumawat2025
reviewed
Jun 6, 2025
...rc/main/java/org/opensearch/cluster/routing/allocation/decider/WarmDiskThresholdDecider.java
Outdated
Show resolved
Hide resolved
skumawat2025
reviewed
Jun 6, 2025
...rc/main/java/org/opensearch/cluster/routing/allocation/decider/WarmDiskThresholdDecider.java
Outdated
Show resolved
Hide resolved
Contributor
|
❌ Gradle check result for 2be2744: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
skumawat2025
approved these changes
Jun 6, 2025
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18456 +/- ##
============================================
+ Coverage 72.66% 72.70% +0.03%
- Complexity 67858 67877 +19
============================================
Files 5521 5521
Lines 312541 312541
Branches 45364 45363 -1
============================================
+ Hits 227113 227238 +125
+ Misses 66903 66769 -134
- Partials 18525 18534 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rayshrey
reviewed
Jun 6, 2025
Contributor
rayshrey
left a comment
rayshrey
left a comment
There was a problem hiding this comment.
Can we add UTs to cover the negative value scenarios ?
added 2 commits
June 7, 2025 11:31
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
Contributor
gbbafna
approved these changes
Jun 10, 2025
abhita
pushed a commit
to abhita/OpenSearch
that referenced
this pull request
Jun 17, 2025
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor fixes in WarmDiskThresholdDecider
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.