Skip to content

Fix UNIX domain socket permission checks on Windows #18764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reta merged 1 commit into from
Jul 16, 2025
Merged

Fix UNIX domain socket permission checks on Windows #18764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions libs/agent-sm/agent/src/main/java/org/opensearch/javaagent/FileInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,23 @@ public static void intercept(@Advice.AllArguments Object[] args, @Advice.Origin
final boolean isDelete = isMutating == false ? name.startsWith("delete") : false;

// This is Windows implementation of UNIX Domain Sockets (close)
if (isDelete == true
&& walker.getCallerClass().getName().equalsIgnoreCase("sun.nio.ch.PipeImpl$Initializer$LoopbackConnector") == true) {
boolean isUnixSocketCaller = false;
if (isDelete == true) {
final Collection<Class<?>> chain = walker.walk(StackCallerClassChainExtractor.INSTANCE);

if (walker.getCallerClass().getName().equalsIgnoreCase("sun.nio.ch.PipeImpl$Initializer$LoopbackConnector") == true) {
isUnixSocketCaller = true;
} else {
for (final Class<?> caller : chain) {
if (caller.getName().equalsIgnoreCase("sun.nio.ch.PipeImpl$Initializer$LoopbackConnector")) {
isUnixSocketCaller = true;
break;
}
}
}
}

if (isDelete == true && isUnixSocketCaller == true) {
final NetPermission permission = new NetPermission("accessUnixDomainSocket");
for (ProtectionDomain domain : callers) {
if (!policy.implies(domain, permission)) {
Expand Down
Loading